From: Tristan Lelong <tristan@lelong.xyz>
To: Joe Perches <joe@perches.com>
Cc: oleg.drokin@intel.com, andreas.dilger@intel.com,
gregkh@linuxfoundation.org, askb23@gmail.com,
john.hammond@intel.com, gdonald@gmail.com, anhlq2110@gmail.com,
fabio.falzoi84@gmail.com, oort10@gmail.com, agimenez@sysvalve.es,
rupran@einserver.de, surya.seetharaman9@gmail.com,
Julia.Lawall@lip6.fr, a.terekhov@gmail.com, liang.zhen@intel.com,
vthakkar1994@gmail.com, amk@cray.com, srikrishanmalik@gmail.com,
rd@radekdostal.com, bergwolf@gmail.com, dan.carpenter@oracle.com,
paul.gortmaker@windriver.com, tapaswenipathak@gmail.com,
email@christophjaeger.info, uja.ornl@gmail.com,
brilliantov@inbox.ru, dmitry.eremin@intel.com,
HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros
Date: Fri, 5 Dec 2014 14:35:48 -0800 [thread overview]
Message-ID: <20141205223548.GA5698@localhost.localdomain> (raw)
In-Reply-To: <1417769047.2721.49.camel@perches.com>
On Fri, Dec 05, 2014 at 12:44:07AM -0800, Joe Perches wrote:
> On Fri, 2014-12-05 at 00:37 -0800, Tristan Lelong wrote:
> > On Fri, Dec 05, 2014 at 12:28:11AM -0800, Joe Perches wrote:
> > > On Fri, 2014-12-05 at 00:03 -0800, Tristan Lelong wrote:
> []
> > > > diff --git a/drivers/staging/lustre/lustre/fld/lproc_fld.c b/drivers/staging/lustre/lustre/fld/lproc_fld.c
> []
> > > > + char name[80];
> []
> > > Why 80? Is there no #define for this length?
> > >
> > No, there is no define.
> >
> > I thought about adding one, but several other files and structure
> > members in the lustre sources are using this specific value, and it
> > seemed like a modification to do in another patch.
> >
> > Let me know if you feel I should do it in a patch serie.
>
> No worries if it's not a new number.
>
> It'd be nice if you would submit a new
> patch with a #define and a conversion
> to use the #define one day.
>
>
No worries, I'll be happy to submit a patch to fix this soon.
Thanks
next prev parent reply other threads:[~2014-12-05 22:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 8:03 [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros Tristan Lelong
2014-12-05 8:28 ` Joe Perches
2014-12-05 8:37 ` Tristan Lelong
2014-12-05 8:44 ` Joe Perches
2014-12-05 22:35 ` Tristan Lelong [this message]
2014-12-05 21:27 ` Greg KH
2014-12-05 22:41 ` Tristan Lelong
2014-12-06 17:05 ` Dilger, Andreas
2014-12-06 22:34 ` Tristan Lelong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141205223548.GA5698@localhost.localdomain \
--to=tristan@lelong.xyz \
--cc=HPDD-discuss@ml01.01.org \
--cc=Julia.Lawall@lip6.fr \
--cc=a.terekhov@gmail.com \
--cc=agimenez@sysvalve.es \
--cc=amk@cray.com \
--cc=andreas.dilger@intel.com \
--cc=anhlq2110@gmail.com \
--cc=askb23@gmail.com \
--cc=bergwolf@gmail.com \
--cc=brilliantov@inbox.ru \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dmitry.eremin@intel.com \
--cc=email@christophjaeger.info \
--cc=fabio.falzoi84@gmail.com \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=john.hammond@intel.com \
--cc=liang.zhen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=oort10@gmail.com \
--cc=paul.gortmaker@windriver.com \
--cc=rd@radekdostal.com \
--cc=rupran@einserver.de \
--cc=srikrishanmalik@gmail.com \
--cc=surya.seetharaman9@gmail.com \
--cc=tapaswenipathak@gmail.com \
--cc=uja.ornl@gmail.com \
--cc=vthakkar1994@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox