public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: Mariusz Gorski <marius.gorski@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: panel: Remove magic numbers in LCD commands
Date: Sat, 6 Dec 2014 00:14:29 +0100	[thread overview]
Message-ID: <20141205231429.GA3051@1wt.eu> (raw)
In-Reply-To: <1417813843-7589-1-git-send-email-marius.gorski@gmail.com>

On Fri, Dec 05, 2014 at 10:10:43PM +0100, Mariusz Gorski wrote:
> Get rid of magic numbers in LCD commands and replace them with defined
> values, so that it's more obvious that the commands are doing.
> 
> Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com>

I didn't remember I wrote something that awful! Obvious ack.

Acked-by: Willy Tarreau <w@1wt.eu>

Thanks,
willy


  reply	other threads:[~2014-12-05 23:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-05 21:10 [PATCH] staging: panel: Remove magic numbers in LCD commands Mariusz Gorski
2014-12-05 23:14 ` Willy Tarreau [this message]
2014-12-06  8:16 ` Sudip Mukherjee
2014-12-06 10:18   ` Mariusz Gorski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141205231429.GA3051@1wt.eu \
    --to=w@1wt.eu \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marius.gorski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox