Re: [PATCH v3 2/2] staging: media: lirc: lirc_zilog.c: keep consistency in dev functions

[Mauro Carvalho Chehab <mchehab@osg.samsung.com>]

Em Fri, 05 Dec 2014 12:35:25 +0000
Luis de Bethencourt <luis@debethencourt.com> escreveu:

> On 5 December 2014 at 12:28, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> 
> > On Thu, Dec 04, 2014 at 10:35:24PM +0000, Luis de Bethencourt wrote:
> > > The previous patch switched some dev functions to move the string to a
> > second
> > > line. Doing this for all similar functions because it makes the driver
> > easier
> > > to read if all similar lines use the same criteria.
> > >
> > > Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> > > ---
> > >  drivers/staging/media/lirc/lirc_zilog.c | 155
> > +++++++++++++++++++++-----------
> > >  1 file changed, 102 insertions(+), 53 deletions(-)
> > >
> > > diff --git a/drivers/staging/media/lirc/lirc_zilog.c
> > b/drivers/staging/media/lirc/lirc_zilog.c
> > > index 8814a7e..af46827 100644
> > > --- a/drivers/staging/media/lirc/lirc_zilog.c
> > > +++ b/drivers/staging/media/lirc/lirc_zilog.c
> > > @@ -322,7 +322,8 @@ static int add_to_buf(struct IR *ir)
> > >       struct IR_tx *tx;
> > >
> > >       if (lirc_buffer_full(rbuf)) {
> > > -             dev_dbg(ir->l.dev, "buffer overflow\n");
> > > +             dev_dbg(ir->l.dev,
> > > +                     "buffer overflow\n");
> >
> > No.  Don't do this.  It's better if it is on one line.
> >
> > regards,
> > dan carpenter
> >
> >
> I was following Mauro's suggestions. As replied to the previous version of
> the patch.
> 
> I agree that in short uses of dev_dbg it adds unnecessary lines and
> vertical length to the file.

In the specific case that Dan pointed, the entire statement fits 
on 80 cols. We only add vertical alignments when it doesn't fit on
80 columns.

> 
> Thanks for looking at my patch :)
> 
> Luis


-- 

Cheers,
Mauro