Re: staging: panel: suggestions needed

Sudip Mukherjee
2014-12-06T15:15:06Z

On Sat, Dec 06, 2014 at 11:28:54AM +0100, Mariusz Gorski wrote:
> Hi Supid,
>
> On Sat, Dec 06, 2014 at 03:39:33PM +0530, Sudip Mukherjee wrote:
> > On Sat, Dec 06, 2014 at 09:41:08AM +0100, Willy Tarreau wrote:
> > > Hi Sudip,
> > >
> > > [ CCing Mariusz who's currently cleaning up the driver ]
> > >
> > > On Tue, Dec 02, 2014 at 01:32:14PM +0530, Sudip Mukherjee wrote:
<snip>
> > > Feel free to do so. I never had the luck to own a 4-line LCD so this
> > > was never even planned. And yes, I remember something about 4-line LCDs
> > > using tricks such as 2x40 addressing being split into 4x20.
> > well, i work in a company which is in embedded training, so i have access to few hardware, and for this i can have 16x2 and 20x4 lcd, but no serial lcd ... :(
>
> Setting the height to 4 is not going to make it work properly - due to
> the way the display is working internally. I also own one in 4x20 size
> and after I get done with the cleaning stuff, I'm going to add proper
> support for it.
ofcourse, just making the height to 4 will not work properly. Height 4 can be there only for user's advantage. but internally we need to monitor if the user is displaying on 3rd or 4th line, then we need to shift that data to the respective position of the 1st and 2nd line to display it properly.

thanks
sudip

>
> > >
> > > > 2) The lcd commands you are writing to the lcd in an escape sequence
> > > > while writing to the lcd. Instead of that why don't we use ioctl for
> > > > lcd commands, and writing to the device will involve only sending data
> > > > to lcd ?
> > >
<snip>
> > > init ->
> > > select_in ->
> > >
> > > And here's the module load command I used to run :
> > > insmod /tmp/panel-0.8.0.o parport=0 lcd_enabled=2 keypad_enabled=1 lcd_width=16 lcd_hwidth=16 lcd_height=2
> > >
> > > Hoping this helps,
> > > Willy
> > >