From: Tristan Lelong <tristan@lelong.xyz>
To: "Dilger, Andreas" <andreas.dilger@intel.com>
Cc: "Drokin, Oleg" <oleg.drokin@intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"standby24x7@gmail.com" <standby24x7@gmail.com>,
"askb23@gmail.com" <askb23@gmail.com>,
"Hammond, John" <john.hammond@intel.com>,
"bergwolf@gmail.com" <bergwolf@gmail.com>,
"Wang, Di" <di.wang@intel.com>,
"Pershin, Mike" <mike.pershin@intel.com>,
"joe@perches.com" <joe@perches.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: lustre: replace static value with define
Date: Sat, 6 Dec 2014 14:41:17 -0800 [thread overview]
Message-ID: <20141206224117.GB17675@dunderer> (raw)
In-Reply-To: <D0A88610.CE1D7%andreas.dilger@intel.com>
On Sat, Dec 06, 2014 at 05:09:29PM +0000, Dilger, Andreas wrote:
> >
> >diff --git a/drivers/staging/lustre/lustre/fld/lproc_fld.c
> >b/drivers/staging/lustre/lustre/fld/lproc_fld.c
> >index 74b4db9..7a55941 100644
> >--- a/drivers/staging/lustre/lustre/fld/lproc_fld.c
> >+++ b/drivers/staging/lustre/lustre/fld/lproc_fld.c
> >@@ -96,7 +96,7 @@ fld_proc_hash_seq_write(struct file *file,
> > char *name;
> > int i;
> >
> >- if (count > 80)
> >+ if (count > LUSTRE_MDT_MAXNAMELEN)
> > return -ENAMETOOLONG;
>
> Sorry for the late reply, but this has nothing to do with an MDT service
> name, so using this #define is misleading here. As I wrote in my other
> email, this only needs to be at most 8 characters.
>
I see that now, I will change that according to the other email.
Do you want me to redo this patch and still define the 80 as LUSTRE_MDT_MAXNAMELEN
but without this last part (just the define and the string length declaration), or
should we just let this go?
Thanks
prev parent reply other threads:[~2014-12-06 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-06 7:16 [PATCH] staging: lustre: replace static value with define Tristan Lelong
2014-12-06 17:09 ` Dilger, Andreas
2014-12-06 22:41 ` Tristan Lelong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141206224117.GB17675@dunderer \
--to=tristan@lelong.xyz \
--cc=andreas.dilger@intel.com \
--cc=askb23@gmail.com \
--cc=bergwolf@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=di.wang@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=john.hammond@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.pershin@intel.com \
--cc=oleg.drokin@intel.com \
--cc=standby24x7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox