Re: [PATCH v4 1/6] mfd: rtsx: add func to split u32 into register

敬锐
2014-12-08T09:59:35Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1823 bytes --]

On 12/08/2014 05:57 PM, Lee Jones wrote:
> On Mon, 08 Dec 2014, æ•¬é” wrote:
>
>> On 12/08/2014 04:49 PM, Lee Jones wrote:
>>>> diff --git a/include/linux/mfd/rtsx_pci.h b/include/linux/mfd/rtsx_pci.h
>>>>> index 74346d5..9234449 100644
>>>>> --- a/include/linux/mfd/rtsx_pci.h
>>>>> +++ b/include/linux/mfd/rtsx_pci.h
>>>>> @@ -558,6 +558,7 @@
>>>>> #define SD_SAMPLE_POINT_CTL 0xFDA7
>>>>> #define SD_PUSH_POINT_CTL 0xFDA8
>>>>> #define SD_CMD0 0xFDA9
>>>>> +#define SD_CMD_START 0x40
>>> This is a different format at the others in the group on two counts;
>>> firstly you have 3 whitespace characters after the #define and
>>> secondly all of the other hex digits in the set are 4 a breast.
>>> Please add the leading zeros to conform to this format.
>>>
>> Hi lee,
>>
>> This format is more readable, add 2 space means this value is
>> in groups under register SD_CMD0, and each register value is u8 type,
>> so use 2 hex digits is right.
>>
>> The original file make register address and its related value separated,
>> and group register together.
>>
>> But I like to write register address and value together,
>> add 2 space for value to indicate this value is related to above register.
>>
>> If we add new address/value, I recommend write register define format as
>> below:
>>
>> #define REGISTER addr
>> #define REG_VAL1 val1
>> #define REG_VAL2 val2
> Okay, I see that there are other occurrences using this format in that
> file. Please consider converting the entire file into this format. I
> don't mind it either way, but it looks odd if they are mixed.
>
we will reformat it in the near future.

regards.
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dÊ‡Ú™ë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥