public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Rabin Vincent <rabin.vincent@axis.com>,
	Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	linux-kernel@vger.kernel.org, rabin@rab.in,
	Rabin Vincent <rabinv@axis.com>
Subject: Re: [PATCH 3/3] perf: bench: fix memcpy/memset output
Date: Mon, 8 Dec 2014 11:25:33 +0100	[thread overview]
Message-ID: <20141208102533.GB19134@gmail.com> (raw)
In-Reply-To: <1417535441-3965-3-git-send-email-rabin.vincent@axis.com>


* Rabin Vincent <rabin.vincent@axis.com> wrote:

> The memcpy and memset benchmarks return bogus results when iterations >
> 0 because the iterations value is not taken into account when
> calculating the final result:
> 
>  $ perf bench mem memset --only-prefault --length 1GB --iterations 1
>  # Running 'mem/memset' benchmark:
>  # Copying 1GB Bytes ...
> 
>        20.798669 GB/Sec (with prefault)
>  $ perf bench mem memset --only-prefault --length 1GB --iterations 10
>  # Running 'mem/memset' benchmark:
>  # Copying 1GB Bytes ...
> 
>         2.086576 GB/Sec (with prefault)
>  $ perf bench mem memset --only-prefault --length 1GB --iterations 100
>  # Running 'mem/memset' benchmark:
>  # Copying 1GB Bytes ...
> 
>       212.840917 MB/Sec (with prefault)
> 
> Fix this.
> 
> Signed-off-by: Rabin Vincent <rabin.vincent@axis.com>

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

  reply	other threads:[~2014-12-08 10:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-02 15:50 [PATCH 1/3] perf: bench: prepare memcpy for merge Rabin Vincent
2014-12-02 15:50 ` [PATCH 2/3] perf: bench: merge memset into memcpy Rabin Vincent
2014-12-12  8:16   ` [tip:perf/urgent] perf bench: Merge " tip-bot for Rabin Vincent
2014-12-02 15:50 ` [PATCH 3/3] perf: bench: fix memcpy/memset output Rabin Vincent
2014-12-08 10:25   ` Ingo Molnar [this message]
2014-12-12  8:16   ` [tip:perf/urgent] perf bench: Fix " tip-bot for Rabin Vincent
2014-12-12  8:15 ` [tip:perf/urgent] perf bench: Prepare memcpy for merge tip-bot for Rabin Vincent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141208102533.GB19134@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@infradead.org \
    --cc=acme@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    --cc=rabin.vincent@axis.com \
    --cc=rabin@rab.in \
    --cc=rabinv@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox