public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Leitner <dev@g0hl1n.net>
To: Arnd Bergmann <arnd@arndb.de>,
	"Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: ioc4: fix variable may be used uninitialized warning
Date: Mon, 8 Dec 2014 14:18:37 +0100	[thread overview]
Message-ID: <20141208141837.752a9968@frodo> (raw)
In-Reply-To: <4066664.BgJJnCmQ3h@wuerfel>

On Mon, 08 Dec 2014 13:42:47 +0100
Arnd Bergmann <arnd@arndb.de> wrote:

> On Monday 08 December 2014 13:27:20 Richard Leitner wrote:
> > 
> > As far as I can tell 'start' cannot really be used uninitialized
> > here, but for the sanity of gcc output explicitly initialize it.
> > Same goes for the 'end' variable.
> 
> Prabhakar Lad also sent a patch for this already, which was lacking
> a good patch description. Your patch does this slightly better but
> still fails to explain how you concluded it was safe and you don't
> really explain why you initialize the 'end' variable that we don't
> even get a warning about.

Oops, I'm sorry, I haven't seen the patch and the answers to it.

According to the comments by Andrew a simplification of this code
section would be nice. I think it should be possible to do this in a
way that the initialize-to-zero won't be needed anymore.

Prabhakar Lad, are you working on this already?
If not I'll take a look at it.

regards,
richard


  reply	other threads:[~2014-12-08 13:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08 12:27 [PATCH] misc: ioc4: fix variable may be used uninitialized warning Richard Leitner
2014-12-08 12:42 ` Arnd Bergmann
2014-12-08 13:18   ` Richard Leitner [this message]
2014-12-08 13:34     ` Prabhakar Lad
2014-12-08 15:28       ` [PATCH] misc: ioc4: simplify wave period measurement in clock_calibrate Richard Leitner
2014-12-08 15:46         ` Arnd Bergmann
2014-12-08 15:58           ` Richard Leitner
2014-12-08 15:54         ` Paul Bolle
2014-12-08 21:03           ` Richard Leitner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141208141837.752a9968@frodo \
    --to=dev@g0hl1n.net \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prabhakar.csengg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox