From: Jeremiah Mahler <jmmahler@gmail.com>
To: George McCollister <george.mccollister@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: add nt124 usb to serial driver
Date: Mon, 8 Dec 2014 16:29:11 -0800 [thread overview]
Message-ID: <20141209002911.GA3003@hudson.localdomain> (raw)
In-Reply-To: <1418081057-25283-1-git-send-email-george.mccollister@gmail.com>
George,
On Mon, Dec 08, 2014 at 05:24:17PM -0600, George McCollister wrote:
> This driver is for the NovaTech 124 4x serial expansion board for the
> NovaTech OrionLXm.
>
> Firmware source code can be found here:
> https://github.com/novatechweb/nt124
>
> Signed-off-by: George McCollister <george.mccollister@gmail.com>
> ---
> drivers/usb/serial/Kconfig | 9 +
> drivers/usb/serial/Makefile | 1 +
> drivers/usb/serial/nt124.c | 429 ++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 439 insertions(+)
> create mode 100644 drivers/usb/serial/nt124.c
>
> diff --git a/drivers/usb/serial/Kconfig b/drivers/usb/serial/Kconfig
[...]
It applies to next without any errors, there are no checkpatch issues
other than recommending updating the MAINTAINERS file, and I can't find
any other obvious problems. Looks good to me.
Reviewed-by: Jeremiah Mahler <jmmahler@gmail.com>
--
- Jeremiah Mahler
next prev parent reply other threads:[~2014-12-09 0:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 23:24 [PATCH] USB: serial: add nt124 usb to serial driver George McCollister
2014-12-09 0:29 ` Jeremiah Mahler [this message]
2014-12-09 0:51 ` George McCollister
2014-12-10 13:04 ` Johan Hovold
2014-12-11 9:05 ` Karl Palsson
2014-12-12 15:01 ` George McCollister
2014-12-14 17:51 ` George McCollister
2014-12-15 9:52 ` Johan Hovold
2014-12-15 16:09 ` George McCollister
2014-12-16 12:52 ` Johan Hovold
2014-12-15 9:42 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209002911.GA3003@hudson.localdomain \
--to=jmmahler@gmail.com \
--cc=george.mccollister@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox