Re: [PATCH 3/8] perf data: Add perf data to CTF conversion support

[Jiri Olsa <jolsa@redhat.com>]

On Mon, Dec 08, 2014 at 05:13:23PM +0900, Namhyung Kim wrote:
> On Thu, Dec 4, 2014 at 1:23 AM, Jiri Olsa <jolsa@kernel.org> wrote:
> > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> > index 33864dd316e5..2d3229ec0a23 100644
> > --- a/tools/perf/Makefile.perf
> > +++ b/tools/perf/Makefile.perf
> > @@ -402,6 +402,10 @@ LIB_OBJS += $(OUTPUT)util/tsc.o
> >  LIB_OBJS += $(OUTPUT)util/cloexec.o
> >  LIB_OBJS += $(OUTPUT)util/thread-stack.o
> >
> > +ifneq ($(NO_LIBBABELTRACE),1)
> 
> I think we usually do it with just "ifndef".

ok

SNIP

> > +       }
> > +
> > +       if (type & PERF_SAMPLE_TID) {
> > +               ret = value_set_s32(cw, event, "tid", sample->tid);
> > +               if (ret)
> > +                       return -1;
> > +
> > +               ret = value_set_s32(cw, event, "pid", sample->tid);
> 
> sample->pid ?

yes

> 
> 
> > +               if (ret)
> > +                       return -1;
> > +       }
> > +
> > +       if ((type & PERF_SAMPLE_ID) ||
> > +           (type & PERF_SAMPLE_IDENTIFIER)) {
> > +               ret = value_set_u64(cw, event, "id", sample->id);
> > +               if (ret)
> > +                       return -1;
> > +       }
> > +
> > +       if (type & PERF_SAMPLE_STREAM_ID) {
> > +               ret = value_set_u64(cw, event, "stream_id", sample->id);
> 
> sample->stream_id ?

yes

thanks,
jirka