Re: [PATCHv4] INPUT: Route keyboard LEDs through the generic LEDs layer.

Dmitry Torokhov
2014-12-19T23:07:26Z

On Sat, Dec 20, 2014 at 12:02:53AM +0100, Pavel Machek wrote:
> On Fri 2014-12-19 23:59:33, Samuel Thibault wrote:
> > Andrew Morton, le Fri 19 Dec 2014 14:46:41 -0800, a écrit :
> > > > Changed in this version:
> > > > - Use kcalloc instead of kzalloc
> > > > - to avoid any mutex order violation, defer LED update into a work callback.
> > >
> > > Confused. This patch is identical to the one that's presently in -mm.
> >
> > Well, yes: I'm submitting the latest version of this patch to Dmitry,
> > i.e. including the fixes that happened in the -mm tree.
>
> Andrew, do you think you could send the patch to Dmitry? He has been
> ignoring it for way too long... and it should be slightly harder for
> him to ignore patch from you...

I'll keep ignoring the patch until someone will figure out how to make new way
of handling LEDs play well with the current way (via writing to evdev). That
means not treating access to evdev as "raw" and ignoring LED trigger remapping
done in LED layer. So far I just heard that it is not a problem and nobody uses
evdev interface...

Thanks.

--
Dmitry