From: Al Viro <viro@ZenIV.linux.org.uk>
To: Shalin Mehta <shalinmehta85@gmail.com>
Cc: andreas.dilger@intel.com, gregkh@linuxfoundation.org,
bergwolf@gmail.com, gdonald@gmail.com, peterz@infradead.org,
tranmanphong@gmail.com, massa.nomura@gmail.com,
HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, majordomo@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: Fix the warning messages about casting without __user macro
Date: Wed, 10 Dec 2014 07:09:59 +0000 [thread overview]
Message-ID: <20141210070957.GN22149@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1418194573-1271-1-git-send-email-shalinmehta85@gmail.com>
On Tue, Dec 09, 2014 at 10:56:12PM -0800, Shalin Mehta wrote:
> From: Shalin Mehta <shalinmehta85@gmail.com>
>
> This issue is showed up while compiling with sparse. The iov_base in struct iovec struct explicitly declares that the assigned value should be user space pointer with __user macro. Where as here, the __user macro isn't used while casting.
... and pointers are not user space ones at all. Which is to say, quit
messing with casts; it's not struct iovec. Proper fix is to replace
it here (and in almost all places throughout drivers/staging/lustre) with
struct kvec. And yes, such a patch had been sent. Still not applied,
AFAICS...
next prev parent reply other threads:[~2014-12-10 7:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 6:56 [PATCH] staging: lustre: Fix the warning messages about casting without __user macro Shalin Mehta
2014-12-10 7:09 ` Al Viro [this message]
2014-12-10 14:49 ` Greg KH
2015-01-09 19:38 ` Andrey Utkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141210070957.GN22149@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=HPDD-discuss@ml01.01.org \
--cc=andreas.dilger@intel.com \
--cc=bergwolf@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=majordomo@vger.kernel.org \
--cc=massa.nomura@gmail.com \
--cc=peterz@infradead.org \
--cc=shalinmehta85@gmail.com \
--cc=tranmanphong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox