From: Joe Thornber <thornber@redhat.com>
To: Akira Hayakawa <ruby.wktk@gmail.com>
Cc: ejt@redhat.com, dm-devel@redhat.com, gregkh@linuxfoundation.org,
snitzer@redhat.com, agk@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [dm-devel] [PATCH] staging: writeboost: Add dm-writeboost
Date: Wed, 10 Dec 2014 13:13:25 +0000 [thread overview]
Message-ID: <20141210131325.GD21108@debian> (raw)
In-Reply-To: <548843A0.6040906@gmail.com>
On Wed, Dec 10, 2014 at 09:59:12PM +0900, Akira Hayakawa wrote:
> Joe,
>
> I appreciate your continuous work.
>
> Is that read or write?
> The difference between Type 0 and 1 should only show up in write path.
> So is it write test?
Yes, writing across the whole device using 'dd'.
These are the tests:
dmtest list --suite writeboost -n /wipe_device/
> And what is the unit of each result?
seconds.
>
> > So maybe it's just volume of IO that's causing the problem? What's
> > the difference between Type 0 and Type 1? In the code I notice you
> > have 'rambuf' structures, are you caching IO in memory?
> "rambuf" is a temporary space that every write data comes in.
> 127*4KB data are once stored there and 4KB metadata section are added
> then it becomes a log and flushed to the cache device sequentially (512KB each).
So you copy the bio payload to a different block of ram and then
complete the bio? Or does the rambuf refer to the bio payload
directly?
> By the way,
> I think more clearer discussion can be done if tests are done on physical machines
> to isolate things relevant to VM. I will also add these tests to dmts later and
> run on my machine.
> But, it will be much better if we have good server with RAID-ed backing store
> and the newest SSD (How would it be if it's PCI-e SSD)...
I generally find it quicker to investigate problems on the machine
that are actually exhibiting the problem ;) Seriously though, you're
asking us to send this upstream; it needs to work on consumer level
hardware.
I've got a big machine with Fusion IO storage that I can run the same
tests on later.
- Joe
next prev parent reply other threads:[~2014-12-10 13:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-07 12:35 [PATCH] staging: writeboost: Add dm-writeboost Akira Hayakawa
2014-12-07 20:08 ` Greg KH
2014-12-07 21:04 ` Akira Hayakawa
2014-12-09 15:12 ` [dm-devel] " Joe Thornber
2014-12-09 15:48 ` Mike Snitzer
2014-12-10 10:21 ` Akira Hayakawa
2014-12-10 10:00 ` [dm-devel] [PATCH] " Joe Thornber
2014-12-10 11:00 ` Akira Hayakawa
2014-12-10 11:22 ` Joe Thornber
2014-12-10 12:33 ` Joe Thornber
2014-12-10 12:59 ` Akira Hayakawa
2014-12-10 13:13 ` Joe Thornber [this message]
2014-12-10 13:31 ` Akira Hayakawa
2014-12-10 13:42 ` Joe Thornber
2014-12-10 14:43 ` Akira Hayakawa
2014-12-12 12:51 ` Marian Csontos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141210131325.GD21108@debian \
--to=thornber@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=ejt@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ruby.wktk@gmail.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox