public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] perf kvm stat live: mark events as (x86 only) in help output
@ 2014-12-10 13:28 Christian Borntraeger
  2014-12-10 13:57 ` David Ahern
  2014-12-12  8:18 ` [tip:perf/urgent] perf kvm stat live: Mark " tip-bot for Alexander Yarygin
  0 siblings, 2 replies; 4+ messages in thread
From: Christian Borntraeger @ 2014-12-10 13:28 UTC (permalink / raw)
  To: Jiri Olsa, Arnaldo Carvalho de Melo
  Cc: linux-kernel, Alexander Yarygin, Christian Borntraeger

From: Alexander Yarygin <yarygin@linux.vnet.ibm.com>

The mmio and ioport events are useful only on x86.

Signed-off-by: Alexander Yarygin <yarygin@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 tools/perf/builtin-kvm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
index b65eb050..612e8f9 100644
--- a/tools/perf/builtin-kvm.c
+++ b/tools/perf/builtin-kvm.c
@@ -1268,7 +1268,8 @@ static int kvm_events_live(struct perf_kvm_stat *kvm,
 		OPT_UINTEGER('d', "display", &kvm->display_time,
 			"time in seconds between display updates"),
 		OPT_STRING(0, "event", &kvm->report_event, "report event",
-			"event for reporting: vmexit, mmio, ioport"),
+			"event for reporting: "
+			"vmexit, mmio (x86 only), ioport (x86 only)"),
 		OPT_INTEGER(0, "vcpu", &kvm->trace_vcpu,
 			"vcpu id to report"),
 		OPT_STRING('k', "key", &kvm->sort_key, "sort-key",
-- 
1.9.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] perf kvm stat live: mark events as (x86 only) in help output
  2014-12-10 13:28 [PATCH] perf kvm stat live: mark events as (x86 only) in help output Christian Borntraeger
@ 2014-12-10 13:57 ` David Ahern
  2014-12-10 15:10   ` Arnaldo Carvalho de Melo
  2014-12-12  8:18 ` [tip:perf/urgent] perf kvm stat live: Mark " tip-bot for Alexander Yarygin
  1 sibling, 1 reply; 4+ messages in thread
From: David Ahern @ 2014-12-10 13:57 UTC (permalink / raw)
  To: Christian Borntraeger, Jiri Olsa, Arnaldo Carvalho de Melo
  Cc: linux-kernel, Alexander Yarygin

On 12/10/14 6:28 AM, Christian Borntraeger wrote:
> From: Alexander Yarygin <yarygin@linux.vnet.ibm.com>
>
> The mmio and ioport events are useful only on x86.
>
> Signed-off-by: Alexander Yarygin <yarygin@linux.vnet.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>   tools/perf/builtin-kvm.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
> index b65eb050..612e8f9 100644
> --- a/tools/perf/builtin-kvm.c
> +++ b/tools/perf/builtin-kvm.c
> @@ -1268,7 +1268,8 @@ static int kvm_events_live(struct perf_kvm_stat *kvm,
>   		OPT_UINTEGER('d', "display", &kvm->display_time,
>   			"time in seconds between display updates"),
>   		OPT_STRING(0, "event", &kvm->report_event, "report event",
> -			"event for reporting: vmexit, mmio, ioport"),
> +			"event for reporting: "
> +			"vmexit, mmio (x86 only), ioport (x86 only)"),
>   		OPT_INTEGER(0, "vcpu", &kvm->trace_vcpu,
>   			"vcpu id to report"),
>   		OPT_STRING('k', "key", &kvm->sort_key, "sort-key",
>

Acked-by: David Ahern <dsahern@gmail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] perf kvm stat live: mark events as (x86 only) in help output
  2014-12-10 13:57 ` David Ahern
@ 2014-12-10 15:10   ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-12-10 15:10 UTC (permalink / raw)
  To: David Ahern
  Cc: Christian Borntraeger, Jiri Olsa, linux-kernel, Alexander Yarygin

Em Wed, Dec 10, 2014 at 06:57:13AM -0700, David Ahern escreveu:
> On 12/10/14 6:28 AM, Christian Borntraeger wrote:
> >diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
> >  		OPT_STRING(0, "event", &kvm->report_event, "report event",
> >-			"event for reporting: vmexit, mmio, ioport"),
> >+			"event for reporting: "
> >+			"vmexit, mmio (x86 only), ioport (x86 only)"),
> 
> Acked-by: David Ahern <dsahern@gmail.com>

Thanks, applied to my local perf/core branch.

- Arnaldo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [tip:perf/urgent] perf kvm stat live: Mark events as (x86 only) in help output
  2014-12-10 13:28 [PATCH] perf kvm stat live: mark events as (x86 only) in help output Christian Borntraeger
  2014-12-10 13:57 ` David Ahern
@ 2014-12-12  8:18 ` tip-bot for Alexander Yarygin
  1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Alexander Yarygin @ 2014-12-12  8:18 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: tglx, borntraeger, hpa, yarygin, jolsa, dsahern, mingo, acme,
	linux-kernel

Commit-ID:  99d348a84c2118ed04c9b72168787f55e2fe33a5
Gitweb:     http://git.kernel.org/tip/99d348a84c2118ed04c9b72168787f55e2fe33a5
Author:     Alexander Yarygin <yarygin@linux.vnet.ibm.com>
AuthorDate: Wed, 10 Dec 2014 14:28:10 +0100
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 10 Dec 2014 12:08:59 -0300

perf kvm stat live: Mark events as (x86 only) in help output

The mmio and ioport events are useful only on x86.

Signed-off-by: Alexander Yarygin <yarygin@linux.vnet.ibm.com>
Acked-by: David Ahern <dsahern@gmail.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/1418218090-20718-1-git-send-email-borntraeger@de.ibm.com
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-kvm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
index 3c0f3d4..0894a81 100644
--- a/tools/perf/builtin-kvm.c
+++ b/tools/perf/builtin-kvm.c
@@ -1293,7 +1293,8 @@ static int kvm_events_live(struct perf_kvm_stat *kvm,
 		OPT_UINTEGER('d', "display", &kvm->display_time,
 			"time in seconds between display updates"),
 		OPT_STRING(0, "event", &kvm->report_event, "report event",
-			"event for reporting: vmexit, mmio, ioport"),
+			"event for reporting: "
+			"vmexit, mmio (x86 only), ioport (x86 only)"),
 		OPT_INTEGER(0, "vcpu", &kvm->trace_vcpu,
 			"vcpu id to report"),
 		OPT_STRING('k', "key", &kvm->sort_key, "sort-key",

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-12-12  8:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-10 13:28 [PATCH] perf kvm stat live: mark events as (x86 only) in help output Christian Borntraeger
2014-12-10 13:57 ` David Ahern
2014-12-10 15:10   ` Arnaldo Carvalho de Melo
2014-12-12  8:18 ` [tip:perf/urgent] perf kvm stat live: Mark " tip-bot for Alexander Yarygin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox