Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in vmbus_establish_gpadl()

Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in vmbus_establish_gpadl()

[Greg KH]

On Wed, Dec 10, 2014 at 11:42:43AM -0800, K. Y. Srinivasan wrote:
> Fix a bug in vmbus_establish_gpadl(). I would like to
> thank Michael Brown <mcb30@ipxe.org> for seeing this bug.

Then use the "Reported-by:" tag with his name in this patch please.

thanks,

greg k-h

RE: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in vmbus_establish_gpadl()

[KY Srinivasan]

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Wednesday, December 10, 2014 11:00 AM
> To: KY Srinivasan
> Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org;
> olaf@aepfle.de; apw@canonical.com; jasowang@redhat.com;
> mcb30@ipxe.org
> Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in
> vmbus_establish_gpadl()
> 
> On Wed, Dec 10, 2014 at 11:42:43AM -0800, K. Y. Srinivasan wrote:
> > Fix a bug in vmbus_establish_gpadl(). I would like to thank Michael
> > Brown <mcb30@ipxe.org> for seeing this bug.
> 
> Then use the "Reported-by:" tag with his name in this patch please.

Will do. I will resend it.
> 
> thanks,
> 
> greg k-h

[PATCH 1/1] Drivers: hv: vmbus: Fix a bug in vmbus_establish_gpadl()

[K. Y. Srinivasan]

Fix a bug in vmbus_establish_gpadl(). I would like to
thank Michael Brown <mcb30@ipxe.org> for seeing this bug.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 drivers/hv/channel.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index 433f72a..c76ffbe 100644
--- a/drivers/hv/channel.c
+++ b/drivers/hv/channel.c
@@ -366,8 +366,8 @@ int vmbus_establish_gpadl(struct vmbus_channel *channel, void *kbuffer,
 	unsigned long flags;
 	int ret = 0;
 
-	next_gpadl_handle = atomic_read(&vmbus_connection.next_gpadl_handle);
-	atomic_inc(&vmbus_connection.next_gpadl_handle);
+	next_gpadl_handle =
+		(atomic_inc_return(&vmbus_connection.next_gpadl_handle) - 1);
 
 	ret = create_gpadl_header(kbuffer, size, &msginfo, &msgcount);
 	if (ret)
-- 
1.7.4.1