The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: David Hildenbrand <dahi@linux.vnet.ibm.com>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, heiko.carstens@de.ibm.com,
	borntraeger@de.ibm.com, rafael.j.wysocki@intel.com,
	peterz@infradead.org, oleg@redhat.com, bp@suse.de,
	jkosina@suse.cz
Subject: Re: [PATCH v4] CPU hotplug: active_writer not woken up in some cases - deadlock
Date: Wed, 10 Dec 2014 20:23:40 +0100	[thread overview]
Message-ID: <20141210202340.1cc25999@thinkpad-w530> (raw)
In-Reply-To: <20141210160025.GR25340@linux.vnet.ibm.com>

only thing that is bugging me is this part. Without the lock we can't
> > guarantee that another get_online_cpus() just arrived and bumped the refcount
> > to 0.
> > 
> > Of course this only applies to misuse of put/get_online_cpus.
> > 
> > We could hack some loop that tries to cmp_xchng with the old value until it
> > fits to work around this, but wouldn't make the code any better readable.
> 
> Well, we didn't have this diagnostic in the original, so one approach
> would be to simply leave it out.  Another approach would be to just
> have the WARN_ON() without the attempt to fix it up.
> 
> 							Thanx, Paul

Well, I think the WARN_ON would be sufficient for debugging purposes.

Thanks!

David


  reply	other threads:[~2014-12-10 19:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-10 13:22 [PATCH v4] CPU hotplug: active_writer not woken up in some cases - deadlock David Hildenbrand
2014-12-10 13:26 ` David Hildenbrand
2014-12-10 16:00   ` Paul E. McKenney
2014-12-10 19:23     ` David Hildenbrand [this message]
2014-12-10 17:50 ` Oleg Nesterov
2014-12-10 19:21   ` David Hildenbrand
2014-12-11  9:56   ` David Hildenbrand
2014-12-12  8:46   ` David Hildenbrand
2014-12-14 19:20     ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141210202340.1cc25999@thinkpad-w530 \
    --to=dahi@linux.vnet.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=bp@suse.de \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox