The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: kbuild test robot <fengguang.wu@intel.com>
To: Alan Tull <atull@opensource.altera.com>
Cc: kbuild-all@01.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH socfpga-nex] staging: fpga manager: socfpga_fpga_ops can be static
Date: Thu, 11 Dec 2014 09:43:24 +0800	[thread overview]
Message-ID: <20141211014324.GA73956@lkp-sb04> (raw)
In-Reply-To: <201412110903.GCuPHwdi%fengguang.wu@intel.com>

drivers/staging/fpga/socfpga.c:655:25: sparse: symbol 'socfpga_fpga_ops' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 socfpga.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fpga/socfpga.c b/drivers/staging/fpga/socfpga.c
index 4440b84..ae9a2f1 100644
--- a/drivers/staging/fpga/socfpga.c
+++ b/drivers/staging/fpga/socfpga.c
@@ -652,7 +652,7 @@ static int socfpga_fpga_resume(struct fpga_manager *mgr)
 	return ret;
 }
 
-struct fpga_manager_ops socfpga_fpga_ops = {
+static struct fpga_manager_ops socfpga_fpga_ops = {
 	.reset = socfpga_fpga_reset,
 	.state = socfpga_fpga_ops_state,
 	.write_init = socfpga_fpga_ops_configure_init,

  reply	other threads:[~2014-12-11  1:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-11  1:43 [socfpga-nex:for_next-fpgamgr-without-overlays-v4.3 8/9] drivers/staging/fpga/socfpga.c:655:25: sparse: symbol 'socfpga_fpga_ops' was not declared. Should it be static? kbuild test robot
2014-12-11  1:43 ` kbuild test robot [this message]
2014-12-11 20:40   ` [PATCH socfpga-nex] staging: fpga manager: socfpga_fpga_ops can be static One Thousand Gnomes
2014-12-12 15:31     ` atull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141211014324.GA73956@lkp-sb04 \
    --to=fengguang.wu@intel.com \
    --cc=atull@opensource.altera.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox