Re: [PATCH v2 1/2] sched: add cond_resched_irq()

Luis R. Rodriguez
2014-12-11T21:06:51Z

On Thu, Dec 11, 2014 at 06:31:54AM -0700, Jan Beulich wrote:
> >>> On 11.12.14 at 00:34, <mcgrof@do-not-panic.com> wrote:
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -4239,6 +4239,16 @@ int __sched _cond_resched(void)
> > }
> > EXPORT_SYMBOL(_cond_resched);
> >
> > +int __sched cond_resched_irq(void)
> > +{
> > + if (should_resched()) {
> > + preempt_schedule_irq();
> > + return 1;
> > + }
> > + return 0;
> > +}
> > +EXPORT_SYMBOL_GPL(cond_resched_irq);
>
> Do you really want to export to modules a symbol like this?

You mean lets not, true and good point. Let's see if seems
if we go with Andy's suggestion we may not need this anyway.

Luis