From: "Luis R. Rodriguez" <mcgrof@suse.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
Juergen Gross <JGross@suse.com>,
luto@amacapital.net, david.vrabel@citrix.com,
rostedt@goodmis.org, masami.hiramatsu.pt@hitachi.com,
peterz@infradead.org, x86@kernel.org, tglx@linutronix.de,
xen-devel@lists.xenproject.org, konrad.wilk@oracle.com,
mingo@redhat.com, Borislav Petkov <bp@suse.de>,
bpoirier@suse.de, linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: [PATCH v2 1/2] sched: add cond_resched_irq()
Date: Thu, 11 Dec 2014 22:06:49 +0100 [thread overview]
Message-ID: <20141211210649.GR25677@wotan.suse.de> (raw)
In-Reply-To: <5489AADA020000780004EFB9@suse.com>
On Thu, Dec 11, 2014 at 06:31:54AM -0700, Jan Beulich wrote:
> >>> On 11.12.14 at 00:34, <mcgrof@do-not-panic.com> wrote:
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -4239,6 +4239,16 @@ int __sched _cond_resched(void)
> > }
> > EXPORT_SYMBOL(_cond_resched);
> >
> > +int __sched cond_resched_irq(void)
> > +{
> > + if (should_resched()) {
> > + preempt_schedule_irq();
> > + return 1;
> > + }
> > + return 0;
> > +}
> > +EXPORT_SYMBOL_GPL(cond_resched_irq);
>
> Do you really want to export to modules a symbol like this?
You mean lets not, true and good point. Let's see if seems
if we go with Andy's suggestion we may not need this anyway.
Luis
next prev parent reply other threads:[~2014-12-11 21:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 23:34 [PATCH v2 0/2] x86: add xen hypercall preemption Luis R. Rodriguez
2014-12-10 23:34 ` [PATCH v2 1/2] sched: add cond_resched_irq() Luis R. Rodriguez
2014-12-11 13:31 ` Jan Beulich
[not found] ` <5489AADA020000780004EFB9@suse.com>
2014-12-11 21:06 ` Luis R. Rodriguez [this message]
2014-12-10 23:34 ` [PATCH v2 2/2] x86/xen: allow privcmd hypercalls to be preempted Luis R. Rodriguez
2014-12-10 23:51 ` Andy Lutomirski
2014-12-11 0:55 ` Luis R. Rodriguez
2014-12-11 1:04 ` Andy Lutomirski
2014-12-11 11:09 ` [Xen-devel] " David Vrabel
2014-12-11 21:05 ` Luis R. Rodriguez
2014-12-11 0:29 ` H. Peter Anvin
2014-12-11 1:03 ` Luis R. Rodriguez
2014-12-11 18:47 ` H. Peter Anvin
2014-12-11 20:39 ` Luis R. Rodriguez
2014-12-18 19:23 ` [Xen-devel] " Konrad Rzeszutek Wilk
2015-01-13 21:21 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141211210649.GR25677@wotan.suse.de \
--to=mcgrof@suse.com \
--cc=JBeulich@suse.com \
--cc=JGross@suse.com \
--cc=bp@suse.de \
--cc=bpoirier@suse.de \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mcgrof@do-not-panic.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox