From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Vishnu Patekar <vishnupatekar0510@gmail.com>
Cc: linux-sunxi@googlegroups.com, dmitry.torokhov@gmail.com,
linux@arm.linux.org.uk, leafy.myeh@newbietech.com,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
vishnupatekar <VishnuPatekar0510@gmail.com>
Subject: Re: [PATCHv2 3/3] ARM:dts:sunxi:ps2 dt nodes for A10/A20 PS2 controller.
Date: Thu, 11 Dec 2014 22:15:50 +0100 [thread overview]
Message-ID: <20141211211550.GJ8739@lukather> (raw)
In-Reply-To: <CAEzqOZu49Z99B4DWvuD=E2BKs7ihSVAunshheUn=Z-VAqivUxA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]
Hi,
Please keep the Cc list.
On Wed, Dec 10, 2014 at 01:39:52AM +0530, Vishnu Patekar wrote:
> > > --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> > > +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> > > @@ -112,6 +112,19 @@
> > > pinctrl-0 = <&uart0_pins_a>;
> > > status = "okay";
> > > };
> > > + /* PS2 0 and PS2 1 are disabled by default
> > > + To enable PS2 0 and PS2 1 uncomment below ps20 and ps21
> > nodes
> > > + Please note that ps20 pins conflict with HDMI on Lime2
> > Board*/
> > > + /*ps20: ps2@0x01c2a000 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&ps2_0_pins>;
> > > + status = "okay";
> > > + };
> > > + ps21: ps2@0x01c2a400 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&ps2_1_pins>;
> > > + status = "okay";
> > > + };*/
> >
> > Hmmm, no, no comments in the DTS.
> >
> > Especially when it's that trivial to enable.
>
> Okie, I'll just keep ps20 and ps21 nodes commented.
No, the comments themselves were great. But the nodes themselves
shouldn't be there in the first place.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next parent reply other threads:[~2014-12-11 21:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAEzqOZu49Z99B4DWvuD=E2BKs7ihSVAunshheUn=Z-VAqivUxA@mail.gmail.com>
2014-12-11 21:15 ` Maxime Ripard [this message]
2014-12-06 23:15 [PATCHv2 0/3] ARM:sunxi:ps2 Added support for A10/A20 ps2 controller vishnupatekar
2014-12-06 23:15 ` [PATCHv2 3/3] ARM:dts:sunxi:ps2 dt nodes for A10/A20 PS2 controller vishnupatekar
2014-12-08 22:22 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141211211550.GJ8739@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=leafy.myeh@newbietech.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=vishnupatekar0510@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox