From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965767AbaLKXt4 (ORCPT ); Thu, 11 Dec 2014 18:49:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58876 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965300AbaLKXty (ORCPT ); Thu, 11 Dec 2014 18:49:54 -0500 Date: Fri, 12 Dec 2014 01:49:36 +0200 From: "Michael S. Tsirkin" To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, Rusty Russell , virtualization@lists.linux-foundation.org, cornelia.huck@de.ibm.com, linux-arch@vger.kernel.org Subject: Re: [PATCH RFC 3/5] pci: add pci_iomap_range Message-ID: <20141211234936.GB9439@redhat.com> References: <1418326570-9541-1-git-send-email-mst@redhat.com> <1418326570-9541-4-git-send-email-mst@redhat.com> <11102634.nzYXXfUH5X@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11102634.nzYXXfUH5X@wuerfel> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 11, 2014 at 11:27:54PM +0100, Arnd Bergmann wrote: > On Thursday 11 December 2014 21:37:34 Michael S. Tsirkin wrote: > > if (flags & IORESOURCE_MEM) { > > - if (flags & IORESOURCE_CACHEABLE) > > + if (!force_nocache && (flags & IORESOURCE_CACHEABLE)) > > return ioremap(start, len); > > return ioremap_nocache(start, len); > > } > > > > ioremap is the same as ioremap_nocache, so this doesn't really make any > sense. IORESOURCE_CACHEABLE is practically only set for ROM bars, which > we rarely map. > > Arnd Hmm I think you are right. It's an old patch - I think at one point in time we did set it when we now set IORESOURCE_PREFETCH. I'll drop this parameter. -- MST