From: Johan Hovold <johan@kernel.org>
To: George McCollister <george.mccollister@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
linux-usb@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] USB: serial: add nt124 usb to serial driver
Date: Mon, 15 Dec 2014 10:52:38 +0100 [thread overview]
Message-ID: <20141215095238.GB6778@localhost> (raw)
In-Reply-To: <CAFSKS=MH0CU=t-TyHgcOun050EBQawkaDXfSN2OoC6MpZKgjmw@mail.gmail.com>
On Sun, Dec 14, 2014 at 11:51:11AM -0600, George McCollister wrote:
> Johan,
>
> While working on the tx_empty changes you suggested it occurred to me
> that it might not be obvious to others that the firmware doesn't send
> a packet with the NT124_CTRL_TXEMPTY flag cleared when it begins
> transmitting. The practical implication is that if the driver sets
> tx_empty = true when it sees NT124_CTRL_TXEMPTY, tx_empty must be
> reset to false somewhere when more data is transmitted. Perhaps I
> could add prepare_write_buffer and do it in there before calling
> usb_serial_generic_prepare_write_buffer(). Does that sound acceptable?
Hmm. There's no way to query that flag? And the status is sent (as bulk
in data) periodically or only when data has been received? And not when
the actual status changes?
A potential problem with using prepare_write_buffer would be on failures
to submit the write urb, in which case this flag might never be cleared.
Johan
next prev parent reply other threads:[~2014-12-15 9:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 23:24 [PATCH] USB: serial: add nt124 usb to serial driver George McCollister
2014-12-09 0:29 ` Jeremiah Mahler
2014-12-09 0:51 ` George McCollister
2014-12-10 13:04 ` Johan Hovold
2014-12-11 9:05 ` Karl Palsson
2014-12-12 15:01 ` George McCollister
2014-12-14 17:51 ` George McCollister
2014-12-15 9:52 ` Johan Hovold [this message]
2014-12-15 16:09 ` George McCollister
2014-12-16 12:52 ` Johan Hovold
2014-12-15 9:42 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215095238.GB6778@localhost \
--to=johan@kernel.org \
--cc=george.mccollister@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox