From: Mark Rutland <mark.rutland@arm.com>
To: Jason Cooper <jason@lakedaemon.net>
Cc: Eddie Huang <eddie.huang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
"srv_heupstream@mediatek.com" <srv_heupstream@mediatek.com>,
Pawel Moll <Pawel.Moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Olof Johansson <olof@lixom.net>,
"Joe.C" <yingjoe.chen@mediatek.com>,
Robert Richter <rrichter@cavium.com>,
Mark Brown <broonie@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Sascha Hauer <kernel@pengutronix.de>,
"yh.chen@mediatek.com" <yh.chen@mediatek.com>
Subject: Re: [PATCH 3/4] arm64: dts: Add mediatek MT8173 SoC and evaluation board dts and Makefile
Date: Mon, 15 Dec 2014 13:32:08 +0000 [thread overview]
Message-ID: <20141215133208.GC8264@leverpostej> (raw)
In-Reply-To: <20141212164254.GK22670@titan.lakedaemon.net>
On Fri, Dec 12, 2014 at 04:42:54PM +0000, Jason Cooper wrote:
> On Fri, Dec 12, 2014 at 04:08:25PM +0800, Eddie Huang wrote:
> > On Thu, 2014-12-11 at 18:02 +0000, Mark Rutland wrote:
> > > On Wed, Dec 10, 2014 at 10:50:01AM +0000, Eddie Huang wrote:
> ...
> > > > + memory {
> > >
> > > Nit: should be memory@40000000 (and you'll need to add device_type =
> > > "memory").
> > >
> > > > + reg = <0 0x40000000 0 0x40000000>;
> > > > + };
> >
> > skeleton.dtsi already has /memory node with address-cells=2,
> > size-cells=1, which will cause build warning if I change to use
> > memory@40000000, because we use size-cells=2. I will not include
> > skeleton.dtsi and follow your suggestion in next version.
>
> There's skeleton64.dtsi in arch/arm/boot/dts (arm 32bit has LPAE-enabled
> systems). Perhaps we should come up with a way to share both across the
> arches?
As I mentioned in my other reply [1], I think if anything it would be
better to get rid of the skeleton dtsi entirely.
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-December/310617.html
Thanks,
Mark.
next prev parent reply other threads:[~2014-12-15 13:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1418208602-35584-1-git-send-email-eddie.huang@mediatek.com>
[not found] ` <1418208602-35584-3-git-send-email-eddie.huang@mediatek.com>
2014-12-10 11:00 ` [PATCH 2/4] irqchip: mediatek: Add support for mt8173 Arnd Bergmann
2014-12-10 14:37 ` Yingjoe Chen
2014-12-10 14:41 ` Arnd Bergmann
[not found] ` <1418208602-35584-4-git-send-email-eddie.huang@mediatek.com>
2014-12-10 14:27 ` [PATCH 3/4] arm64: dts: Add mediatek MT8173 SoC and evaluation board dts and Makefile Yingjoe Chen
2014-12-10 14:50 ` Matthias Brugger
2014-12-11 12:47 ` Eddie Huang
2014-12-11 13:02 ` Matthias Brugger
2014-12-12 7:45 ` Eddie Huang
2014-12-11 18:02 ` Mark Rutland
2014-12-12 6:52 ` Sascha Hauer
2014-12-15 11:28 ` Mark Rutland
[not found] ` <1418371705.423.31.camel@mtksdaap41>
2014-12-12 16:42 ` Jason Cooper
2014-12-15 13:32 ` Mark Rutland [this message]
2014-12-15 12:59 ` Mark Rutland
[not found] ` <1418719615.8392.17.camel@mtksdaap41>
2014-12-16 10:17 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215133208.GC8264@leverpostej \
--to=mark.rutland@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=Will.Deacon@arm.com \
--cc=broonie@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=rrichter@cavium.com \
--cc=srv_heupstream@mediatek.com \
--cc=tglx@linutronix.de \
--cc=yh.chen@mediatek.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox