From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chris Rorvick <chris@rorvick.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
devel@driverdev.osuosl.org, HPDD-discuss@ml01.01.org,
Greg Donald <gdonald@gmail.com>,
James Simmons <uja.ornl@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
linux-kernel@vger.kernel.org, Fabian Frederick <fabf@skynet.be>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Andriy Skulysh <Andriy_Skulysh@xyratex.com>,
"John L. Hammond" <john.hammond@intel.com>
Subject: Re: [PATCH] drivers: staging: lustre: Use mult if units not specified
Date: Tue, 16 Dec 2014 12:41:09 +0300 [thread overview]
Message-ID: <20141216094109.GH4856@mwanda> (raw)
In-Reply-To: <1418708509-18196-1-git-send-email-chris@rorvick.com>
On Mon, Dec 15, 2014 at 11:41:49PM -0600, Chris Rorvick wrote:
> Units can be passed to lprocfs_write_frac_u64_helper() via a suffix
> (e.g., "...K", "...M", etc.) tacked onto the value. A comment states
> that "specified units override the multiplier," though the multiplier is
> overridden regardless. Update the conditional logic so that it only
> applies when units are specified.
>
That introduces a bug. We need to take the initial '-' into
consideration. Just remove the condition. Also remove the "mult"
parameter since that is always 1.
bool negative = false;
...
if (*pbuf == '-') {
negative = true;
pbuf++;
}
...
mult = negative ? -units : units;
regards,
dan carpenter
next prev parent reply other threads:[~2014-12-16 9:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 5:41 [PATCH] drivers: staging: lustre: Use mult if units not specified Chris Rorvick
2014-12-16 9:41 ` Dan Carpenter [this message]
2014-12-16 11:14 ` Dilger, Andreas
2014-12-16 11:35 ` Dan Carpenter
2014-12-16 12:53 ` Chris Rorvick
2014-12-16 13:54 ` Dan Carpenter
2014-12-16 14:04 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141216094109.GH4856@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Andriy_Skulysh@xyratex.com \
--cc=HPDD-discuss@ml01.01.org \
--cc=Julia.Lawall@lip6.fr \
--cc=andreas.dilger@intel.com \
--cc=chris@rorvick.com \
--cc=devel@driverdev.osuosl.org \
--cc=fabf@skynet.be \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.hammond@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=uja.ornl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox