Re: [PATCH] drivers: staging: lustre: Use mult if units not specified

[Dan Carpenter <dan.carpenter@oracle.com>]

On Tue, Dec 16, 2014 at 11:14:35AM +0000, Dilger, Andreas wrote:
>
> Sorry, that isn't right.  Chris' patch is actually doing the right thing
> to check for units > 1.

It's not right because it discards the negative.


>  The proposed change above discards "mult"
> entirely, which breaks the users of this function that are not in this
> file (e.g. osc_cached_mb_seq_write() or ll_max_cached_mb_seq_write())
> that have tunables in units of MB by default, but can also use parameters
> with units like "4.5G" for convenience.

I think you are confusing lprocfs_write_frac_helper() and
lprocfs_write_frac_u64_helper().  There is only one caller for this
function.

! grep lprocfs_write_frac_u64_helper drivers/staging/lustre/ -R | grep -v smatch  | grep -v '\.i:'
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c:        return lprocfs_write_frac_u64_helper(buffer, count, val, 1);
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c:int lprocfs_write_frac_u64_helper(const char *buffer, unsigned long count,
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c:EXPORT_SYMBOL(lprocfs_write_frac_u64_helper);
drivers/staging/lustre/lustre/include/lprocfs_status.h:extern int lprocfs_write_frac_u64_helper(const char *buffer,

regards,
dan carpenter