Re: [git pull] vfs.git pile 2

Linus Torvalds
2016-12-18T02:49:58Z

On Fri, Dec 16, 2016 at 2:12 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> In this pile:
> * autofs-namespace series
> * dedupe stuff
> * more struct path constification

When looking at the conflict, I looked at that part of
vfs_clone_file_prep_inodes(), and reacted to the insanity.

WTF?

/* Zero length dedupe exits immediately; reflink goes to EOF. */
if (*len == 0) {
if (is_dedupe) {
*len = 0;
return 0;
}
*len = isize - pos_in;
}

I'll just leave you to read through that part a bit more. Because
there are two completely insane things going on in that code sequence.

Linus