[PATCH] Staging: comedi: fix blank line coding style in comedi_bond.c

[PATCH] Staging: comedi: fix blank line coding style in comedi_bond.c

[Frederic Jacob]

This is a patch to the comedi_bond.c file that fixes up a blank line after declaration warning found by the checkpatch.pl tool
Signed-off-by: Frederic Jacob <frederic.jacob.78@gmail.com>
---
This is my first patch that I send. It is for the Eudyptula chalange task 10.
 drivers/staging/comedi/drivers/comedi_bond.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/comedi/drivers/comedi_bond.c b/drivers/staging/comedi/drivers/comedi_bond.c
index 85b2f4a..221d381 100644
--- a/drivers/staging/comedi/drivers/comedi_bond.c
+++ b/drivers/staging/comedi/drivers/comedi_bond.c
@@ -261,6 +261,7 @@ static int do_dev_config(struct comedi_device *dev, struct comedi_devconfig *it)
 			{
 				/* Append dev:subdev to devpriv->name */
 				char buf[20];
+
 				snprintf(buf, sizeof(buf), "%u:%u ",
 					 bdev->minor, bdev->subdev);
 				strlcat(devpriv->name, buf,
-- 
1.9.1

Re: [PATCH] Staging: comedi: fix blank line coding style in comedi_bond.c

[Greg KH]

On Wed, Dec 17, 2014 at 09:35:41PM -0500, Frederic Jacob wrote:
> This is a patch to the comedi_bond.c file that fixes up a blank line after declaration warning found by the checkpatch.pl tool

Please line-wrap your line properly.


> Signed-off-by: Frederic Jacob <frederic.jacob.78@gmail.com>

And provide an empty line before the signed-off-by: line.

Can you fix that up and resend?

thanks,

greg k-h

[PATCHv2] Staging: comedi: fix blank line coding style in comedi_bond.c

[Frederic Jacob]

 This is a patch to the comedi_bond.c file that fixes up a blank line after
 declaration warning found by the checkpatch.pl tool 

Signed-off-by: Frederic Jacob <frederic.jacob.78@gmail.com>
---
v2: Fix description line-wrap and add a line before Signed-off-by
 drivers/staging/comedi/drivers/comedi_bond.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/comedi/drivers/comedi_bond.c b/drivers/staging/comedi/drivers/comedi_bond.c
index 85b2f4a..221d381 100644
--- a/drivers/staging/comedi/drivers/comedi_bond.c
+++ b/drivers/staging/comedi/drivers/comedi_bond.c
@@ -261,6 +261,7 @@ static int do_dev_config(struct comedi_device *dev, struct comedi_devconfig *it)
 			{
 				/* Append dev:subdev to devpriv->name */
 				char buf[20];
+
 				snprintf(buf, sizeof(buf), "%u:%u ",
 					 bdev->minor, bdev->subdev);
 				strlcat(devpriv->name, buf,
-- 
1.9.1