From: Namhyung Kim <namhyung@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] tools lib traceevent: Add support for IP address formats
Date: Thu, 18 Dec 2014 14:04:59 +0900 [thread overview]
Message-ID: <20141218050459.GD20215@sejong> (raw)
In-Reply-To: <549258DB.1010408@gmail.com>
On Wed, Dec 17, 2014 at 09:32:27PM -0700, David Ahern wrote:
> On 12/17/14 9:26 PM, Namhyung Kim wrote:
> >
> >It'd be better if we do it like below..
> >
> > char i = *ptr++;
> >
> >Why not passing ptr + 1 to print_ip_arg()?
> >
>
> That parsing loop is a bit weird - and deep. And I only wanted to consume
> 'pi' and 'pI' with parse_ip_arg if and only if the next letters are '4', '6'
> and 'S'.
Yeah, I know - but I still think you can pass ptr + 1 (but not update
ptr) since everytime you only access to ptr + 1 unless I missed it.
Consuming ptr depends on the return value so it's irrelevant whether
you pass ptr or (ptr + 1) IMHO.
Thanks,
Namhyung
next prev parent reply other threads:[~2014-12-18 5:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 20:29 [PATCH] tools lib traceevent: Add support for IP address formats David Ahern
2014-12-18 4:26 ` Namhyung Kim
2014-12-18 4:32 ` David Ahern
2014-12-18 5:04 ` Namhyung Kim [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-12-18 15:10 David Ahern
2014-12-18 15:52 ` Arnaldo Carvalho de Melo
2014-12-18 15:59 ` David Ahern
2014-12-18 16:27 ` Steven Rostedt
2014-12-18 22:16 ` Arnaldo Carvalho de Melo
2014-12-18 22:50 ` David Ahern
2014-12-18 21:45 ` Valdis.Kletnieks
2014-12-18 22:13 ` David Ahern
2014-12-19 1:41 ` David Ahern
2014-12-22 17:01 ` Jiri Olsa
2014-12-22 17:10 ` David Ahern
2014-12-22 17:28 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141218050459.GD20215@sejong \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox