Re: [PATCH] media: rc: Replace timeval with ktime_t in imon.c

Chunyan Zhang
2014-12-18T11:39:39Z

On Thu, Dec 18, 2014 at 7:00 PM, Mauro Carvalho Chehab
<mchehab@osg.samsung.com> wrote:
> Em Thu, 18 Dec 2014 17:38:14 +0800
> Chunyan Zhang <zhang.chunyan@linaro.org> escreveu:
>
>> On Thu, Dec 18, 2014 at 3:50 PM, Arnd Bergmann <arnd@linaro.org> wrote:
>> > On Thursday 18 December 2014 11:37:13 Chunyan Zhang wrote:
>> >> This patch changes the 32-bit time type (timeval) to the 64-bit one
>> >> (ktime_t), since 32-bit time types will break in the year 2038.
>> >>
>> >> I use ktime_t instead of all uses of timeval in imon.c
>> >>
>> >> This patch also changes do_gettimeofday() to ktime_get() accordingly,
>> >> since ktime_get returns a ktime_t, but do_gettimeofday returns a
>> >> struct timeval, and the other reason is that ktime_get() uses
>> >> the monotonic clock.
>> >>
>> >> This patch use a new function which is provided by another patch listed below
>> >> to get the millisecond time difference.
>> >
>> > The patch looks great. Just a few small details that could still be
>> > improved:
>
> Yes, patch looks OK. After addressing the bits pointed by Arnd:
>
> Acked-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
>
> Feel free to merge via y2038 tree.
>
Ok, thank you, I'll send the updated patch-set soon.

Chunyan