From: Peter Zijlstra <peterz@infradead.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] perf ftrace: Factor regs retrieval for function tracer
Date: Thu, 18 Dec 2014 16:10:20 +0100 [thread overview]
Message-ID: <20141218151020.GF30905@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20141218142827.GB18898@krava.brq.redhat.com>
On Thu, Dec 18, 2014 at 03:28:27PM +0100, Jiri Olsa wrote:
> > Would not something like:
> >
> > struct pt_regs *regs;
> >
> > entry = perf_trace_buf_prepare(ENTRY_SIZE, TRACE_FN, ®s, &rctx);
> > if (!pt_regs) {
> > perf_fetch_caller_regs(regs);
> > pt_regs = regs;
> > }
> >
> > Be simpler?
>
> well, I wanted to omit touching the '__perf_regs' var
> in perf_trace_buf_prepare:
>
> if (regs)
> *regs = this_cpu_ptr(&__perf_regs[*rctxp]);
OK, fair enough I suppose. Thanks!
next prev parent reply other threads:[~2014-12-18 15:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 11:50 [PATCH] perf: Avoid horrible stack usage Peter Zijlstra
2014-12-17 14:31 ` Jiri Olsa
2014-12-17 15:35 ` Peter Zijlstra
2014-12-17 15:45 ` Jiri Olsa
2014-12-18 14:08 ` [PATCH] perf ftrace: Factor regs retrieval for function tracer Jiri Olsa
2014-12-18 14:20 ` Peter Zijlstra
2014-12-18 14:28 ` Jiri Olsa
2014-12-18 15:10 ` Peter Zijlstra [this message]
2015-01-14 19:19 ` [tip:perf/core] perf: Avoid horrible stack usage tip-bot for Peter Zijlstra (Intel)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141218151020.GF30905@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox