From: kbuild test robot <fengguang.wu@intel.com>
To: Thierry Reding <treding@nvidia.com>
Cc: kbuild-all@01.org, Daniel Vetter <daniel.vetter@ffwll.ch>,
David Airlie <airlied@linux.ie>, Dave Airlie <airlied@redhat.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Zach Reizner <zachr@google.com>,
Fabian Frederick <fabf@skynet.be>,
Martin Koegler <martin.koegler@chello.at>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drm/fb-helper: fix simple_return.cocci warnings
Date: Fri, 19 Dec 2014 19:14:13 +0800 [thread overview]
Message-ID: <20141219111413.GA17269@athens> (raw)
In-Reply-To: <201412191911.BLNbzNHF%fengguang.wu@intel.com>
drivers/gpu/drm/cirrus/cirrus_fbdev.c:330:1-4: WARNING: end returns can be simpified
Simplify a trivial if-return sequence. Possibly combine with a
preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci
CC: Thierry Reding <treding@nvidia.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
cirrus_fbdev.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
--- a/drivers/gpu/drm/cirrus/cirrus_fbdev.c
+++ b/drivers/gpu/drm/cirrus/cirrus_fbdev.c
@@ -327,11 +327,7 @@ int cirrus_fbdev_init(struct cirrus_devi
/* disable all the possible outputs/crtcs before entering KMS mode */
drm_helper_disable_unused_functions(cdev->dev);
- ret = drm_fb_helper_initial_config(&gfbdev->helper, bpp_sel);
- if (ret)
- return ret;
-
- return 0;
+ return drm_fb_helper_initial_config(&gfbdev->helper, bpp_sel);
}
void cirrus_fbdev_fini(struct cirrus_device *cdev)
parent reply other threads:[~2014-12-19 11:15 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <201412191911.BLNbzNHF%fengguang.wu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141219111413.GA17269@athens \
--to=fengguang.wu@intel.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabf@skynet.be \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.koegler@chello.at \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=treding@nvidia.com \
--cc=zachr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox