* [PATCH] drm/fb-helper: fix simple_return.cocci warnings
[not found] <201412191911.BLNbzNHF%fengguang.wu@intel.com>
@ 2014-12-19 11:14 ` kbuild test robot
0 siblings, 0 replies; only message in thread
From: kbuild test robot @ 2014-12-19 11:14 UTC (permalink / raw)
To: Thierry Reding
Cc: kbuild-all, Daniel Vetter, David Airlie, Dave Airlie,
Russell King, Zach Reizner, Fabian Frederick, Martin Koegler,
dri-devel, linux-kernel
drivers/gpu/drm/cirrus/cirrus_fbdev.c:330:1-4: WARNING: end returns can be simpified
Simplify a trivial if-return sequence. Possibly combine with a
preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci
CC: Thierry Reding <treding@nvidia.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
cirrus_fbdev.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
--- a/drivers/gpu/drm/cirrus/cirrus_fbdev.c
+++ b/drivers/gpu/drm/cirrus/cirrus_fbdev.c
@@ -327,11 +327,7 @@ int cirrus_fbdev_init(struct cirrus_devi
/* disable all the possible outputs/crtcs before entering KMS mode */
drm_helper_disable_unused_functions(cdev->dev);
- ret = drm_fb_helper_initial_config(&gfbdev->helper, bpp_sel);
- if (ret)
- return ret;
-
- return 0;
+ return drm_fb_helper_initial_config(&gfbdev->helper, bpp_sel);
}
void cirrus_fbdev_fini(struct cirrus_device *cdev)
^ permalink raw reply [flat|nested] only message in thread