* Re: [PATCH] lustre: ptlrpc: add "ptlrpc_internal.h" to sec_gc.c
2014-12-20 20:27 [PATCH] lustre: ptlrpc: add "ptlrpc_internal.h" to sec_gc.c sbaugh
@ 2014-12-20 20:27 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2014-12-20 20:27 UTC (permalink / raw)
To: sbaugh
Cc: Oleg Drokin, Andreas Dilger, moderated list:STAGING - LUSTRE...,
open list:STAGING SUBSYSTEM, open list
On Sat, Dec 20, 2014 at 03:27:31PM -0500, sbaugh wrote:
> ptlrpc_internal.h contains the prototypes for sptlrpc_gc_init() and
> sptlrpc_gc_fini(), which are defined in sec_gc.c.
>
> This removes the following sparse warnings:
>
> drivers/staging/lustre/lustre/ptlrpc/sec_gc.c:217:5: warning: symbol 'sptlrpc_gc_init' was not declared. Should it be static?
> drivers/staging/lustre/lustre/ptlrpc/sec_gc.c:241:6: warning: symbol 'sptlrpc_gc_fini' was not declared. Should it be static?
>
> Signed-off-by: sbaugh <sbaugh@andrew.cmu.edu>
I'm guessing this is not the name you use to sign a legal document,
right? Please fix that up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] lustre: ptlrpc: add "ptlrpc_internal.h" to sec_gc.c
@ 2014-12-20 20:27 sbaugh
2014-12-20 20:27 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: sbaugh @ 2014-12-20 20:27 UTC (permalink / raw)
To: Oleg Drokin, Andreas Dilger, Greg Kroah-Hartman, sbaugh,
moderated list:STAGING - LUSTRE..., open list:STAGING SUBSYSTEM,
open list
ptlrpc_internal.h contains the prototypes for sptlrpc_gc_init() and
sptlrpc_gc_fini(), which are defined in sec_gc.c.
This removes the following sparse warnings:
drivers/staging/lustre/lustre/ptlrpc/sec_gc.c:217:5: warning: symbol 'sptlrpc_gc_init' was not declared. Should it be static?
drivers/staging/lustre/lustre/ptlrpc/sec_gc.c:241:6: warning: symbol 'sptlrpc_gc_fini' was not declared. Should it be static?
Signed-off-by: sbaugh <sbaugh@andrew.cmu.edu>
---
drivers/staging/lustre/lustre/ptlrpc/sec_gc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec_gc.c b/drivers/staging/lustre/lustre/ptlrpc/sec_gc.c
index c500aff..81de68e 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/sec_gc.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/sec_gc.c
@@ -47,6 +47,8 @@
#include "../include/lustre_net.h"
#include "../include/lustre_sec.h"
+#include "ptlrpc_internal.h"
+
#define SEC_GC_INTERVAL (30 * 60)
--
2.1.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] lustre: ptlrpc: add "ptlrpc_internal.h" to sec_gc.c
@ 2014-12-20 20:48 Spencer Baugh
0 siblings, 0 replies; 3+ messages in thread
From: Spencer Baugh @ 2014-12-20 20:48 UTC (permalink / raw)
To: Oleg Drokin, Andreas Dilger, Greg Kroah-Hartman, Spencer Baugh,
moderated list:STAGING - LUSTRE..., open list:STAGING SUBSYSTEM,
open list
ptlrpc_internal.h contains the prototypes for sptlrpc_gc_init() and
sptlrpc_gc_fini(), which are defined in sec_gc.c.
This removes the following sparse warnings:
drivers/staging/lustre/lustre/ptlrpc/sec_gc.c:217:5: warning: symbol 'sptlrpc_gc_init' was not declared. Should it be static?
drivers/staging/lustre/lustre/ptlrpc/sec_gc.c:241:6: warning: symbol 'sptlrpc_gc_fini' was not declared. Should it be static?
Signed-off-by: Spencer Baugh <sbaugh@andrew.cmu.edu>
---
drivers/staging/lustre/lustre/ptlrpc/sec_gc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec_gc.c b/drivers/staging/lustre/lustre/ptlrpc/sec_gc.c
index c500aff..81de68e 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/sec_gc.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/sec_gc.c
@@ -47,6 +47,8 @@
#include "../include/lustre_net.h"
#include "../include/lustre_sec.h"
+#include "ptlrpc_internal.h"
+
#define SEC_GC_INTERVAL (30 * 60)
--
2.1.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-20 20:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-20 20:27 [PATCH] lustre: ptlrpc: add "ptlrpc_internal.h" to sec_gc.c sbaugh
2014-12-20 20:27 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2014-12-20 20:48 Spencer Baugh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox