From: Pavel Machek <pavel@ucw.cz>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: rostedt@goodmis.org, namhyung@kernel.org,
masami.hiramatsu.pt@hitachi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ftracetest: Replace usleep with sleep 0.000001
Date: Sat, 20 Dec 2014 21:42:13 +0100 [thread overview]
Message-ID: <20141220204213.GA16705@amd> (raw)
In-Reply-To: <1418186307-1259-1-git-send-email-mpe@ellerman.id.au>
On Wed 2014-12-10 15:38:27, Michael Ellerman wrote:
> usleep is a Fedoraism, it's not generally available on Debian based
> systems AFAICS.
>
> GNU sleep accepts a floating point argument, so use that instead.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Could ftrace user interface be enhanced not to need random delays?
Pavel
> ---
> tools/testing/selftests/ftrace/test.d/event/event-enable.tc | 6 +++---
> tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> index 668616d9bb03..c5343add3407 100644
> --- a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> +++ b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> @@ -21,7 +21,7 @@ reset_tracer
> do_reset
>
> echo 'sched:sched_switch' > set_event
> -usleep 1
> +sleep 0.000001
>
> count=`cat trace | grep sched_switch | wc -l`
> if [ $count -eq 0 ]; then
> @@ -31,7 +31,7 @@ fi
> do_reset
>
> echo 1 > events/sched/sched_switch/enable
> -usleep 1
> +sleep 0.000001
>
> count=`cat trace | grep sched_switch | wc -l`
> if [ $count -eq 0 ]; then
> @@ -41,7 +41,7 @@ fi
> do_reset
>
> echo 0 > events/sched/sched_switch/enable
> -usleep 1
> +sleep 0.000001
>
> count=`cat trace | grep sched_switch | wc -l`
> if [ $count -ne 0 ]; then
> diff --git a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc
> index 655c415b6e7f..84a2020d4e7b 100644
> --- a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc
> +++ b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc
> @@ -21,7 +21,7 @@ reset_tracer
> do_reset
>
> echo 'sched:*' > set_event
> -usleep 1
> +sleep 0.000001
>
> count=`cat trace | grep -v ^# | awk '{ print $5 }' | sort -u | wc -l`
> if [ $count -lt 3 ]; then
> @@ -31,7 +31,7 @@ fi
> do_reset
>
> echo 1 > events/sched/enable
> -usleep 1
> +sleep 0.000001
>
> count=`cat trace | grep -v ^# | awk '{ print $5 }' | sort -u | wc -l`
> if [ $count -lt 3 ]; then
> @@ -41,7 +41,7 @@ fi
> do_reset
>
> echo 0 > events/sched/enable
> -usleep 1
> +sleep 0.000001
>
> count=`cat trace | grep -v ^# | awk '{ print $5 }' | sort -u | wc -l`
> if [ $count -ne 0 ]; then
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-12-20 20:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 4:38 [PATCH] ftracetest: Replace usleep with sleep 0.000001 Michael Ellerman
2014-12-10 8:19 ` Namhyung Kim
2014-12-11 5:12 ` Masami Hiramatsu
2014-12-11 23:39 ` Michael Ellerman
2014-12-20 20:42 ` Pavel Machek [this message]
2014-12-20 22:07 ` Steven Rostedt
2014-12-23 4:21 ` Namhyung Kim
2014-12-23 7:08 ` Michael Ellerman
2014-12-24 1:00 ` Masami Hiramatsu
2014-12-25 23:17 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141220204213.GA16705@amd \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mpe@ellerman.id.au \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox