From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752645AbaLUSkM (ORCPT ); Sun, 21 Dec 2014 13:40:12 -0500 Received: from mail-wg0-f44.google.com ([74.125.82.44]:50404 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752386AbaLUSkK (ORCPT ); Sun, 21 Dec 2014 13:40:10 -0500 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Guenter Roeck Subject: Re: [PATCH v4] i8k: Autodetect maximal fan speed and fan RPM multiplier Date: Sun, 21 Dec 2014 19:40:06 +0100 User-Agent: KMail/1.13.7 (Linux/3.13.0-44-generic; KDE/4.14.2; x86_64; ; ) Cc: Arnd Bergmann , "Greg Kroah-Hartman" , linux-kernel@vger.kernel.org, Valdis.Kletnieks@vt.edu, Steven Honeyman , Jean Delvare , Gabriele Mazzotta , Jochen Eisinger References: <1419153618-6930-1-git-send-email-pali.rohar@gmail.com> <1419182630-20211-1-git-send-email-pali.rohar@gmail.com> <54971116.8030504@roeck-us.net> In-Reply-To: <54971116.8030504@roeck-us.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4106243.9RsjPEH9Da"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201412211940.06980@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart4106243.9RsjPEH9Da Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Sunday 21 December 2014 19:27:34 Guenter Roeck wrote: > On 12/21/2014 09:23 AM, Pali Roh=C3=A1r wrote: > > This patch adds new function i8k_get_fan_nominal_speed() for > > doing SMM call which will return nominal fan RPM for > > specified fan speed. It returns nominal RPM value at which > > fan operate when speed (0, 1, 2, 3) is set. It looks like > > RPM value is not accurate, but still provides very useful > > information. > >=20 > > First it can be used to validate if certain fan speed could > > be accepted by SMM for setting fan speed and we can use > > this routine to detect maximal fan speed. > >=20 > > Second it returns RPM value, so we can check if value looks > > correct with multiplier 30 or multiplier 1 (until now only > > these two multiplier were used). If RPM value with > > multiplier 30 is too high, then multiplier 1 is used. > >=20 > > In case when SMM reports that new function is not supported > > we will fallback to old hardcoded values. Maximal fan speed > > would be 2 and RPM multiplier 30. > >=20 > > Signed-off-by: Pali Roh=C3=A1r > > Tested-by: Pali Roh=C3=A1r >=20 > Tested-by the submitter is kind of implied. >=20 > Anyway, this patch does not apply to 3.19-rc1, nor to 3.18. > What is your baseline ? Can you rebase to 3.19-rc1 ? > Or do I need to apply some other patch first ? >=20 > Thanks, > Guenter You need to apply these old patches: i8k: Add support for temperature sensor labels i8k: Register only temperature sensors which have labels i8k: Return -ENODATA for invalid temperature i8k: Rework error retries (they are not in 3.18/3.19 yet, but you already reviewed them) And after that you need to apply new pach which I sent hour ago: [PATCH] i8k: Make fan module parameters an unsigned =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart4106243.9RsjPEH9Da Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlSXFAYACgkQi/DJPQPkQ1Jg5QCgpBAzJRZhzagxqWfI5iuOSFTL kSMAoIULTVwGtIImIqFGzg+3Wfk/p0js =DFbD -----END PGP SIGNATURE----- --nextPart4106243.9RsjPEH9Da--