linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dmaengine: rcar-dmac: fix platform_no_drv_owner.cocci warnings
       [not found] <201412181212.KWu8yaD9%fengguang.wu@intel.com>
@ 2014-12-18  4:15 ` kbuild test robot
  2014-12-22 15:11   ` Vinod Koul
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2014-12-18  4:15 UTC (permalink / raw)
  To: Laurent Pinchart
  Cc: kbuild-all, Dan Williams, Vinod Koul, dmaengine, linux-kernel

drivers/dma/sh/rcar-dmac.c:1490:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 rcar-dmac.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/dma/sh/rcar-dmac.c
+++ b/drivers/dma/sh/rcar-dmac.c
@@ -1487,7 +1487,6 @@ MODULE_DEVICE_TABLE(of, rcar_dmac_of_ids
 
 static struct platform_driver rcar_dmac_driver = {
 	.driver		= {
-		.owner	= THIS_MODULE,
 		.pm	= &rcar_dmac_pm,
 		.name	= "rcar-dmac",
 		.of_match_table = rcar_dmac_of_ids,

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dmaengine: rcar-dmac: fix platform_no_drv_owner.cocci warnings
  2014-12-18  4:15 ` [PATCH] dmaengine: rcar-dmac: fix platform_no_drv_owner.cocci warnings kbuild test robot
@ 2014-12-22 15:11   ` Vinod Koul
  2014-12-23  8:49     ` Laurent Pinchart
  0 siblings, 1 reply; 3+ messages in thread
From: Vinod Koul @ 2014-12-22 15:11 UTC (permalink / raw)
  To: kbuild test robot
  Cc: Laurent Pinchart, kbuild-all, Dan Williams, dmaengine,
	linux-kernel

On Thu, Dec 18, 2014 at 12:15:56PM +0800, kbuild test robot wrote:
> drivers/dma/sh/rcar-dmac.c:1490:3-8: No need to set .owner here. The core will do it.
> 
>  Remove .owner field if calls are used which set it automatically
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Laurent,

I am assuming you will apply/fold this one?

-- 
~Vinod
> ---
> 
>  rcar-dmac.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/drivers/dma/sh/rcar-dmac.c
> +++ b/drivers/dma/sh/rcar-dmac.c
> @@ -1487,7 +1487,6 @@ MODULE_DEVICE_TABLE(of, rcar_dmac_of_ids
>  
>  static struct platform_driver rcar_dmac_driver = {
>  	.driver		= {
> -		.owner	= THIS_MODULE,
>  		.pm	= &rcar_dmac_pm,
>  		.name	= "rcar-dmac",
>  		.of_match_table = rcar_dmac_of_ids,

-- 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dmaengine: rcar-dmac: fix platform_no_drv_owner.cocci warnings
  2014-12-22 15:11   ` Vinod Koul
@ 2014-12-23  8:49     ` Laurent Pinchart
  0 siblings, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2014-12-23  8:49 UTC (permalink / raw)
  To: Vinod Koul
  Cc: kbuild test robot, Laurent Pinchart, kbuild-all, Dan Williams,
	dmaengine, linux-kernel

Hi Vinod,

On Monday 22 December 2014 20:41:16 Vinod Koul wrote:
> On Thu, Dec 18, 2014 at 12:15:56PM +0800, kbuild test robot wrote:
> > drivers/dma/sh/rcar-dmac.c:1490:3-8: No need to set .owner here. The core
> > will do it.
> >
> > Remove .owner field if calls are used which set it automatically
> > 
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> > 
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> 
> Laurent,
> 
> I am assuming you will apply/fold this one?

Done already.

> > ---
> > 
> >  rcar-dmac.c |    1 -
> >  1 file changed, 1 deletion(-)
> > 
> > --- a/drivers/dma/sh/rcar-dmac.c
> > +++ b/drivers/dma/sh/rcar-dmac.c
> > @@ -1487,7 +1487,6 @@ MODULE_DEVICE_TABLE(of, rcar_dmac_of_ids
> > 
> >  static struct platform_driver rcar_dmac_driver = {
> >  	.driver		= {
> > -		.owner	= THIS_MODULE,
> >  		.pm	= &rcar_dmac_pm,
> >  		.name	= "rcar-dmac",
> >  		.of_match_table = rcar_dmac_of_ids,

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-12-23  8:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <201412181212.KWu8yaD9%fengguang.wu@intel.com>
2014-12-18  4:15 ` [PATCH] dmaengine: rcar-dmac: fix platform_no_drv_owner.cocci warnings kbuild test robot
2014-12-22 15:11   ` Vinod Koul
2014-12-23  8:49     ` Laurent Pinchart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).