From: Namhyung Kim <namhyung@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Pavel Machek <pavel@ucw.cz>,
Michael Ellerman <mpe@ellerman.id.au>,
masami.hiramatsu.pt@hitachi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ftracetest: Replace usleep with sleep 0.000001
Date: Tue, 23 Dec 2014 13:21:18 +0900 [thread overview]
Message-ID: <20141223042118.GD14960@sejong> (raw)
In-Reply-To: <20141220170725.776363ac@gandalf.local.home>
On Sat, Dec 20, 2014 at 05:07:25PM -0500, Steven Rostedt wrote:
> On Sat, 20 Dec 2014 21:42:13 +0100
> Pavel Machek <pavel@ucw.cz> wrote:
>
> > On Wed 2014-12-10 15:38:27, Michael Ellerman wrote:
> > > usleep is a Fedoraism, it's not generally available on Debian based
> > > systems AFAICS.
> > >
> > > GNU sleep accepts a floating point argument, so use that instead.
> > >
> > > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> >
> > Could ftrace user interface be enhanced not to need random delays?
> >
>
> Not sure what you are talking about. These "random delays" are not for
> the interface, but instead to force some events to happen and to make
> sure they did.
>
> As the subject states, this is for "ftracetest" which is the selftests
> for ftrace.
>
> The usleep is basically a "do something to trigger events", and we
> don't want to wait long in doing it.
Right. AFAIK what ftracetest expects is a scheduler event so it
doesn't need to be the [u]sleep.
Thanks,
Namhyung
next prev parent reply other threads:[~2014-12-23 4:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 4:38 [PATCH] ftracetest: Replace usleep with sleep 0.000001 Michael Ellerman
2014-12-10 8:19 ` Namhyung Kim
2014-12-11 5:12 ` Masami Hiramatsu
2014-12-11 23:39 ` Michael Ellerman
2014-12-20 20:42 ` Pavel Machek
2014-12-20 22:07 ` Steven Rostedt
2014-12-23 4:21 ` Namhyung Kim [this message]
2014-12-23 7:08 ` Michael Ellerman
2014-12-24 1:00 ` Masami Hiramatsu
2014-12-25 23:17 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141223042118.GD14960@sejong \
--to=namhyung@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mpe@ellerman.id.au \
--cc=pavel@ucw.cz \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox