From: samuel kihahu <skihahu@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, HPDD-discuss@ml01.01.org,
andreas.dilger@intel.com, linux-kernel@vger.kernel.org,
oleg.drokin@intel.com
Subject: Re: [PATCH] staging: lustre: cleanup align switch and case
Date: Tue, 23 Dec 2014 07:38:04 +0300 [thread overview]
Message-ID: <20141223043804.GA2623@localhost.localdomain> (raw)
In-Reply-To: <20141222211801.GA29847@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 437 bytes --]
On Mon, Dec 22, 2014 at 01:18:01PM -0800, Greg KH wrote:
> On Mon, Dec 22, 2014 at 11:48:57PM +0300, samuel kihahu wrote:
> > From: skihahu <skihahu@gmail.com>
> >
> > Align switch and case to be at the same indent.
> >
> > Signed-off-by: samuel kihahu <skihahu@gmail.com>
>
> The "From:" and "Signed-off-by:" names don't match, which doesn't make
> much sense, right? Please fix and resend.
>
I have corrected as requested above.
[-- Attachment #2: 0001-staging-lustre-cleanup-align-switch-and-case.patch --]
[-- Type: text/plain, Size: 2037 bytes --]
>From 766dd7eefe8992b90dc69cca085e6719019aae82 Mon Sep 17 00:00:00 2001
From: samuel kihahu <skihahu@gmail.com>
Date: Mon, 22 Dec 2014 18:16:29 +0300
Subject: [PATCH] staging: lustre: cleanup align switch and case
Align switch and case to be at the same indent.
Signed-off-by: samuel kihahu <skihahu@gmail.com>
---
drivers/staging/lustre/lnet/selftest/module.c | 50 +++++++++++++--------------
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/lustre/lnet/selftest/module.c b/drivers/staging/lustre/lnet/selftest/module.c
index 6dd4309..b5f07fa 100644
--- a/drivers/staging/lustre/lnet/selftest/module.c
+++ b/drivers/staging/lustre/lnet/selftest/module.c
@@ -61,31 +61,31 @@ lnet_selftest_fini(void)
int i;
switch (lst_init_step) {
- case LST_INIT_CONSOLE:
- lstcon_console_fini();
- case LST_INIT_FW:
- sfw_shutdown();
- case LST_INIT_RPC:
- srpc_shutdown();
- case LST_INIT_WI_TEST:
- for (i = 0;
- i < cfs_cpt_number(lnet_cpt_table()); i++) {
- if (lst_sched_test[i] == NULL)
- continue;
- cfs_wi_sched_destroy(lst_sched_test[i]);
- }
- LIBCFS_FREE(lst_sched_test,
- sizeof(lst_sched_test[0]) *
- cfs_cpt_number(lnet_cpt_table()));
- lst_sched_test = NULL;
-
- case LST_INIT_WI_SERIAL:
- cfs_wi_sched_destroy(lst_sched_serial);
- lst_sched_serial = NULL;
- case LST_INIT_NONE:
- break;
- default:
- LBUG();
+ case LST_INIT_CONSOLE:
+ lstcon_console_fini();
+ case LST_INIT_FW:
+ sfw_shutdown();
+ case LST_INIT_RPC:
+ srpc_shutdown();
+ case LST_INIT_WI_TEST:
+ for (i = 0;
+ i < cfs_cpt_number(lnet_cpt_table()); i++) {
+ if (lst_sched_test[i] == NULL)
+ continue;
+ cfs_wi_sched_destroy(lst_sched_test[i]);
+ }
+ LIBCFS_FREE(lst_sched_test,
+ sizeof(lst_sched_test[0]) *
+ cfs_cpt_number(lnet_cpt_table()));
+ lst_sched_test = NULL;
+
+ case LST_INIT_WI_SERIAL:
+ cfs_wi_sched_destroy(lst_sched_serial);
+ lst_sched_serial = NULL;
+ case LST_INIT_NONE:
+ break;
+ default:
+ LBUG();
}
return;
}
next prev parent reply other threads:[~2014-12-23 4:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 20:48 [PATCH] staging: lustre: cleanup align switch and case samuel kihahu
2014-12-22 21:18 ` Greg KH
2014-12-23 4:38 ` samuel kihahu [this message]
2014-12-23 5:58 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2014-12-23 7:57 samuel kihahu
2014-12-23 8:54 ` Dan Carpenter
2014-12-23 9:36 ` Jeremiah Mahler
2014-12-23 12:04 samuel kihahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141223043804.GA2623@localhost.localdomain \
--to=skihahu@gmail.com \
--cc=HPDD-discuss@ml01.01.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox