* [PATCH] staging: lustre: cleanup align switch and case
@ 2014-12-22 20:48 samuel kihahu
2014-12-22 21:18 ` Greg KH
0 siblings, 1 reply; 8+ messages in thread
From: samuel kihahu @ 2014-12-22 20:48 UTC (permalink / raw)
Cc: oleg.drokin, andreas.dilger, gregkh, HPDD-discuss, devel,
linux-kernel, skihahu
From: skihahu <skihahu@gmail.com>
Align switch and case to be at the same indent.
Signed-off-by: samuel kihahu <skihahu@gmail.com>
---
drivers/staging/lustre/lnet/selftest/module.c | 50 +++++++++++++--------------
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/lustre/lnet/selftest/module.c b/drivers/staging/lustre/lnet/selftest/module.c
index 6dd4309..b5f07fa 100644
--- a/drivers/staging/lustre/lnet/selftest/module.c
+++ b/drivers/staging/lustre/lnet/selftest/module.c
@@ -61,31 +61,31 @@ lnet_selftest_fini(void)
int i;
switch (lst_init_step) {
- case LST_INIT_CONSOLE:
- lstcon_console_fini();
- case LST_INIT_FW:
- sfw_shutdown();
- case LST_INIT_RPC:
- srpc_shutdown();
- case LST_INIT_WI_TEST:
- for (i = 0;
- i < cfs_cpt_number(lnet_cpt_table()); i++) {
- if (lst_sched_test[i] == NULL)
- continue;
- cfs_wi_sched_destroy(lst_sched_test[i]);
- }
- LIBCFS_FREE(lst_sched_test,
- sizeof(lst_sched_test[0]) *
- cfs_cpt_number(lnet_cpt_table()));
- lst_sched_test = NULL;
-
- case LST_INIT_WI_SERIAL:
- cfs_wi_sched_destroy(lst_sched_serial);
- lst_sched_serial = NULL;
- case LST_INIT_NONE:
- break;
- default:
- LBUG();
+ case LST_INIT_CONSOLE:
+ lstcon_console_fini();
+ case LST_INIT_FW:
+ sfw_shutdown();
+ case LST_INIT_RPC:
+ srpc_shutdown();
+ case LST_INIT_WI_TEST:
+ for (i = 0;
+ i < cfs_cpt_number(lnet_cpt_table()); i++) {
+ if (lst_sched_test[i] == NULL)
+ continue;
+ cfs_wi_sched_destroy(lst_sched_test[i]);
+ }
+ LIBCFS_FREE(lst_sched_test,
+ sizeof(lst_sched_test[0]) *
+ cfs_cpt_number(lnet_cpt_table()));
+ lst_sched_test = NULL;
+
+ case LST_INIT_WI_SERIAL:
+ cfs_wi_sched_destroy(lst_sched_serial);
+ lst_sched_serial = NULL;
+ case LST_INIT_NONE:
+ break;
+ default:
+ LBUG();
}
return;
}
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: lustre: cleanup align switch and case
2014-12-22 20:48 [PATCH] staging: lustre: cleanup align switch and case samuel kihahu
@ 2014-12-22 21:18 ` Greg KH
2014-12-23 4:38 ` samuel kihahu
0 siblings, 1 reply; 8+ messages in thread
From: Greg KH @ 2014-12-22 21:18 UTC (permalink / raw)
To: samuel kihahu
Cc: devel, HPDD-discuss, andreas.dilger, linux-kernel, oleg.drokin
On Mon, Dec 22, 2014 at 11:48:57PM +0300, samuel kihahu wrote:
> From: skihahu <skihahu@gmail.com>
>
> Align switch and case to be at the same indent.
>
> Signed-off-by: samuel kihahu <skihahu@gmail.com>
The "From:" and "Signed-off-by:" names don't match, which doesn't make
much sense, right? Please fix and resend.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: lustre: cleanup align switch and case
2014-12-22 21:18 ` Greg KH
@ 2014-12-23 4:38 ` samuel kihahu
2014-12-23 5:58 ` Greg KH
0 siblings, 1 reply; 8+ messages in thread
From: samuel kihahu @ 2014-12-23 4:38 UTC (permalink / raw)
To: Greg KH; +Cc: devel, HPDD-discuss, andreas.dilger, linux-kernel, oleg.drokin
[-- Attachment #1: Type: text/plain, Size: 437 bytes --]
On Mon, Dec 22, 2014 at 01:18:01PM -0800, Greg KH wrote:
> On Mon, Dec 22, 2014 at 11:48:57PM +0300, samuel kihahu wrote:
> > From: skihahu <skihahu@gmail.com>
> >
> > Align switch and case to be at the same indent.
> >
> > Signed-off-by: samuel kihahu <skihahu@gmail.com>
>
> The "From:" and "Signed-off-by:" names don't match, which doesn't make
> much sense, right? Please fix and resend.
>
I have corrected as requested above.
[-- Attachment #2: 0001-staging-lustre-cleanup-align-switch-and-case.patch --]
[-- Type: text/plain, Size: 2037 bytes --]
>From 766dd7eefe8992b90dc69cca085e6719019aae82 Mon Sep 17 00:00:00 2001
From: samuel kihahu <skihahu@gmail.com>
Date: Mon, 22 Dec 2014 18:16:29 +0300
Subject: [PATCH] staging: lustre: cleanup align switch and case
Align switch and case to be at the same indent.
Signed-off-by: samuel kihahu <skihahu@gmail.com>
---
drivers/staging/lustre/lnet/selftest/module.c | 50 +++++++++++++--------------
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/lustre/lnet/selftest/module.c b/drivers/staging/lustre/lnet/selftest/module.c
index 6dd4309..b5f07fa 100644
--- a/drivers/staging/lustre/lnet/selftest/module.c
+++ b/drivers/staging/lustre/lnet/selftest/module.c
@@ -61,31 +61,31 @@ lnet_selftest_fini(void)
int i;
switch (lst_init_step) {
- case LST_INIT_CONSOLE:
- lstcon_console_fini();
- case LST_INIT_FW:
- sfw_shutdown();
- case LST_INIT_RPC:
- srpc_shutdown();
- case LST_INIT_WI_TEST:
- for (i = 0;
- i < cfs_cpt_number(lnet_cpt_table()); i++) {
- if (lst_sched_test[i] == NULL)
- continue;
- cfs_wi_sched_destroy(lst_sched_test[i]);
- }
- LIBCFS_FREE(lst_sched_test,
- sizeof(lst_sched_test[0]) *
- cfs_cpt_number(lnet_cpt_table()));
- lst_sched_test = NULL;
-
- case LST_INIT_WI_SERIAL:
- cfs_wi_sched_destroy(lst_sched_serial);
- lst_sched_serial = NULL;
- case LST_INIT_NONE:
- break;
- default:
- LBUG();
+ case LST_INIT_CONSOLE:
+ lstcon_console_fini();
+ case LST_INIT_FW:
+ sfw_shutdown();
+ case LST_INIT_RPC:
+ srpc_shutdown();
+ case LST_INIT_WI_TEST:
+ for (i = 0;
+ i < cfs_cpt_number(lnet_cpt_table()); i++) {
+ if (lst_sched_test[i] == NULL)
+ continue;
+ cfs_wi_sched_destroy(lst_sched_test[i]);
+ }
+ LIBCFS_FREE(lst_sched_test,
+ sizeof(lst_sched_test[0]) *
+ cfs_cpt_number(lnet_cpt_table()));
+ lst_sched_test = NULL;
+
+ case LST_INIT_WI_SERIAL:
+ cfs_wi_sched_destroy(lst_sched_serial);
+ lst_sched_serial = NULL;
+ case LST_INIT_NONE:
+ break;
+ default:
+ LBUG();
}
return;
}
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: lustre: cleanup align switch and case
2014-12-23 4:38 ` samuel kihahu
@ 2014-12-23 5:58 ` Greg KH
0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2014-12-23 5:58 UTC (permalink / raw)
To: samuel kihahu
Cc: devel, HPDD-discuss, andreas.dilger, linux-kernel, oleg.drokin
On Tue, Dec 23, 2014 at 07:38:04AM +0300, samuel kihahu wrote:
> On Mon, Dec 22, 2014 at 01:18:01PM -0800, Greg KH wrote:
> > On Mon, Dec 22, 2014 at 11:48:57PM +0300, samuel kihahu wrote:
> > > From: skihahu <skihahu@gmail.com>
> > >
> > > Align switch and case to be at the same indent.
> > >
> > > Signed-off-by: samuel kihahu <skihahu@gmail.com>
> >
> > The "From:" and "Signed-off-by:" names don't match, which doesn't make
> > much sense, right? Please fix and resend.
> >
>
> I have corrected as requested above.
> >From 766dd7eefe8992b90dc69cca085e6719019aae82 Mon Sep 17 00:00:00 2001
> From: samuel kihahu <skihahu@gmail.com>
> Date: Mon, 22 Dec 2014 18:16:29 +0300
> Subject: [PATCH] staging: lustre: cleanup align switch and case
>
> Align switch and case to be at the same indent.
>
> Signed-off-by: samuel kihahu <skihahu@gmail.com>
> ---
> drivers/staging/lustre/lnet/selftest/module.c | 50 +++++++++++++--------------
> 1 file changed, 25 insertions(+), 25 deletions(-)
But this isn't in a form I can apply, please resend in a format I don't
have to hand-edit the email.
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] staging: lustre: cleanup align switch and case
@ 2014-12-23 7:57 samuel kihahu
2014-12-23 8:54 ` Dan Carpenter
2014-12-23 9:36 ` Jeremiah Mahler
0 siblings, 2 replies; 8+ messages in thread
From: samuel kihahu @ 2014-12-23 7:57 UTC (permalink / raw)
To: gregkh; +Cc: oleg.drokin, andreas.dilger, devel, linux-kernel, samuel kihahu
From: samuel kihahu <skihahu@gmail.com>
Align switch and case to be at the same indent.
Signed-off-by: samuel kihahu <skihahu@gmail.com>
---
drivers/staging/lustre/lnet/selftest/module.c | 50 +++++++++++++--------------
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/lustre/lnet/selftest/module.c b/drivers/staging/lustre/lnet/selftest/module.c
index 6dd4309..b5f07fa 100644
--- a/drivers/staging/lustre/lnet/selftest/module.c
+++ b/drivers/staging/lustre/lnet/selftest/module.c
@@ -61,31 +61,31 @@ lnet_selftest_fini(void)
int i;
switch (lst_init_step) {
- case LST_INIT_CONSOLE:
- lstcon_console_fini();
- case LST_INIT_FW:
- sfw_shutdown();
- case LST_INIT_RPC:
- srpc_shutdown();
- case LST_INIT_WI_TEST:
- for (i = 0;
- i < cfs_cpt_number(lnet_cpt_table()); i++) {
- if (lst_sched_test[i] == NULL)
- continue;
- cfs_wi_sched_destroy(lst_sched_test[i]);
- }
- LIBCFS_FREE(lst_sched_test,
- sizeof(lst_sched_test[0]) *
- cfs_cpt_number(lnet_cpt_table()));
- lst_sched_test = NULL;
-
- case LST_INIT_WI_SERIAL:
- cfs_wi_sched_destroy(lst_sched_serial);
- lst_sched_serial = NULL;
- case LST_INIT_NONE:
- break;
- default:
- LBUG();
+ case LST_INIT_CONSOLE:
+ lstcon_console_fini();
+ case LST_INIT_FW:
+ sfw_shutdown();
+ case LST_INIT_RPC:
+ srpc_shutdown();
+ case LST_INIT_WI_TEST:
+ for (i = 0;
+ i < cfs_cpt_number(lnet_cpt_table()); i++) {
+ if (lst_sched_test[i] == NULL)
+ continue;
+ cfs_wi_sched_destroy(lst_sched_test[i]);
+ }
+ LIBCFS_FREE(lst_sched_test,
+ sizeof(lst_sched_test[0]) *
+ cfs_cpt_number(lnet_cpt_table()));
+ lst_sched_test = NULL;
+
+ case LST_INIT_WI_SERIAL:
+ cfs_wi_sched_destroy(lst_sched_serial);
+ lst_sched_serial = NULL;
+ case LST_INIT_NONE:
+ break;
+ default:
+ LBUG();
}
return;
}
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: lustre: cleanup align switch and case
2014-12-23 7:57 samuel kihahu
@ 2014-12-23 8:54 ` Dan Carpenter
2014-12-23 9:36 ` Jeremiah Mahler
1 sibling, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2014-12-23 8:54 UTC (permalink / raw)
To: samuel kihahu; +Cc: gregkh, oleg.drokin, devel, andreas.dilger, linux-kernel
On Tue, Dec 23, 2014 at 10:57:46AM +0300, samuel kihahu wrote:
> From: samuel kihahu <skihahu@gmail.com>
Don't include this unless you are forwarding a patch on behalf of the
original author. Also the capitalization isn't correct. These things
are intended to be a bit formal like signing a legal document.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: lustre: cleanup align switch and case
2014-12-23 7:57 samuel kihahu
2014-12-23 8:54 ` Dan Carpenter
@ 2014-12-23 9:36 ` Jeremiah Mahler
1 sibling, 0 replies; 8+ messages in thread
From: Jeremiah Mahler @ 2014-12-23 9:36 UTC (permalink / raw)
To: samuel kihahu; +Cc: gregkh, oleg.drokin, andreas.dilger, devel, linux-kernel
samuel,
This patch is corrupt and won't apply. I suspect it is due to missing
spaces at the start of each line in the diff.
I recommend using 'git send-email'. But if you are using a different
client have a look at Documentation/email-clients.txt for tips on how to
avoid these problems.
On Tue, Dec 23, 2014 at 10:57:46AM +0300, samuel kihahu wrote:
> From: samuel kihahu <skihahu@gmail.com>
>
> Align switch and case to be at the same indent.
>
> Signed-off-by: samuel kihahu <skihahu@gmail.com>
> ---
> drivers/staging/lustre/lnet/selftest/module.c | 50 +++++++++++++--------------
> 1 file changed, 25 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/selftest/module.c b/drivers/staging/lustre/lnet/selftest/module.c
> index 6dd4309..b5f07fa 100644
> --- a/drivers/staging/lustre/lnet/selftest/module.c
> +++ b/drivers/staging/lustre/lnet/selftest/module.c
> @@ -61,31 +61,31 @@ lnet_selftest_fini(void)
> int i;
>
> switch (lst_init_step) {
> - case LST_INIT_CONSOLE:
> - lstcon_console_fini();
> - case LST_INIT_FW:
> - sfw_shutdown();
> - case LST_INIT_RPC:
> - srpc_shutdown();
> - case LST_INIT_WI_TEST:
> - for (i = 0;
> - i < cfs_cpt_number(lnet_cpt_table()); i++) {
> - if (lst_sched_test[i] == NULL)
> - continue;
> - cfs_wi_sched_destroy(lst_sched_test[i]);
> - }
> - LIBCFS_FREE(lst_sched_test,
> - sizeof(lst_sched_test[0]) *
> - cfs_cpt_number(lnet_cpt_table()));
> - lst_sched_test = NULL;
> -
> - case LST_INIT_WI_SERIAL:
> - cfs_wi_sched_destroy(lst_sched_serial);
> - lst_sched_serial = NULL;
> - case LST_INIT_NONE:
> - break;
> - default:
> - LBUG();
> + case LST_INIT_CONSOLE:
> + lstcon_console_fini();
> + case LST_INIT_FW:
> + sfw_shutdown();
> + case LST_INIT_RPC:
> + srpc_shutdown();
> + case LST_INIT_WI_TEST:
> + for (i = 0;
> + i < cfs_cpt_number(lnet_cpt_table()); i++) {
> + if (lst_sched_test[i] == NULL)
> + continue;
> + cfs_wi_sched_destroy(lst_sched_test[i]);
> + }
> + LIBCFS_FREE(lst_sched_test,
> + sizeof(lst_sched_test[0]) *
> + cfs_cpt_number(lnet_cpt_table()));
> + lst_sched_test = NULL;
> +
> + case LST_INIT_WI_SERIAL:
> + cfs_wi_sched_destroy(lst_sched_serial);
> + lst_sched_serial = NULL;
> + case LST_INIT_NONE:
> + break;
> + default:
> + LBUG();
> }
> return;
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
- Jeremiah Mahler
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] staging: lustre: cleanup align switch and case
@ 2014-12-23 12:04 samuel kihahu
0 siblings, 0 replies; 8+ messages in thread
From: samuel kihahu @ 2014-12-23 12:04 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Samuel Kihahu
Align switch and case to be at the same indent.
Signed-off-by: Samuel Kihahu <skihahu@gmail.com>
---
drivers/staging/lustre/lnet/selftest/module.c | 50 +++++++++++++--------------
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/lustre/lnet/selftest/module.c b/drivers/staging/lustre/lnet/selftest/module.c
index 6dd4309..b5f07fa 100644
--- a/drivers/staging/lustre/lnet/selftest/module.c
+++ b/drivers/staging/lustre/lnet/selftest/module.c
@@ -61,31 +61,31 @@ lnet_selftest_fini(void)
int i;
switch (lst_init_step) {
- case LST_INIT_CONSOLE:
- lstcon_console_fini();
- case LST_INIT_FW:
- sfw_shutdown();
- case LST_INIT_RPC:
- srpc_shutdown();
- case LST_INIT_WI_TEST:
- for (i = 0;
- i < cfs_cpt_number(lnet_cpt_table()); i++) {
- if (lst_sched_test[i] == NULL)
- continue;
- cfs_wi_sched_destroy(lst_sched_test[i]);
- }
- LIBCFS_FREE(lst_sched_test,
- sizeof(lst_sched_test[0]) *
- cfs_cpt_number(lnet_cpt_table()));
- lst_sched_test = NULL;
-
- case LST_INIT_WI_SERIAL:
- cfs_wi_sched_destroy(lst_sched_serial);
- lst_sched_serial = NULL;
- case LST_INIT_NONE:
- break;
- default:
- LBUG();
+ case LST_INIT_CONSOLE:
+ lstcon_console_fini();
+ case LST_INIT_FW:
+ sfw_shutdown();
+ case LST_INIT_RPC:
+ srpc_shutdown();
+ case LST_INIT_WI_TEST:
+ for (i = 0;
+ i < cfs_cpt_number(lnet_cpt_table()); i++) {
+ if (lst_sched_test[i] == NULL)
+ continue;
+ cfs_wi_sched_destroy(lst_sched_test[i]);
+ }
+ LIBCFS_FREE(lst_sched_test,
+ sizeof(lst_sched_test[0]) *
+ cfs_cpt_number(lnet_cpt_table()));
+ lst_sched_test = NULL;
+
+ case LST_INIT_WI_SERIAL:
+ cfs_wi_sched_destroy(lst_sched_serial);
+ lst_sched_serial = NULL;
+ case LST_INIT_NONE:
+ break;
+ default:
+ LBUG();
}
return;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-12-23 12:06 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-22 20:48 [PATCH] staging: lustre: cleanup align switch and case samuel kihahu
2014-12-22 21:18 ` Greg KH
2014-12-23 4:38 ` samuel kihahu
2014-12-23 5:58 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2014-12-23 7:57 samuel kihahu
2014-12-23 8:54 ` Dan Carpenter
2014-12-23 9:36 ` Jeremiah Mahler
2014-12-23 12:04 samuel kihahu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox