* [PATCH] USB: serial: cp210x: Correcting IDs for production CEL MeshConnect USB Stick
@ 2014-12-22 5:33 Preston Fick
2014-12-23 11:24 ` Johan Hovold
0 siblings, 1 reply; 4+ messages in thread
From: Preston Fick @ 2014-12-22 5:33 UTC (permalink / raw)
To: johan; +Cc: linux-usb, linux-kernel, Preston Fick
Signed-off-by: Preston Fick <pffick@gmail.com>
---
drivers/usb/serial/cp210x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index 6c4eb3c..fb8d3fa 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -120,7 +120,7 @@ static const struct usb_device_id id_table[] = {
{ USB_DEVICE(0x10C4, 0x85F8) }, /* Virtenio Preon32 */
{ USB_DEVICE(0x10C4, 0x8664) }, /* AC-Services CAN-IF */
{ USB_DEVICE(0x10C4, 0x8665) }, /* AC-Services OBD-IF */
- { USB_DEVICE(0x10C4, 0x8875) }, /* CEL MeshConnect USB Stick */
+ { USB_DEVICE(0x10C4, 0x8857) }, /* CEL MeshConnect USB Stick */
{ USB_DEVICE(0x10C4, 0x88A4) }, /* MMB Networks ZigBee USB Device */
{ USB_DEVICE(0x10C4, 0x88A5) }, /* Planet Innovation Ingeni ZigBee USB Device */
{ USB_DEVICE(0x10C4, 0x8946) }, /* Ketra N1 Wireless Interface */
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] USB: serial: cp210x: Correcting IDs for production CEL MeshConnect USB Stick
2014-12-22 5:33 [PATCH] USB: serial: cp210x: Correcting IDs for production CEL MeshConnect USB Stick Preston Fick
@ 2014-12-23 11:24 ` Johan Hovold
0 siblings, 0 replies; 4+ messages in thread
From: Johan Hovold @ 2014-12-23 11:24 UTC (permalink / raw)
To: Preston Fick; +Cc: johan, linux-usb, linux-kernel
On Sun, Dec 21, 2014 at 11:33:39PM -0600, Preston Fick wrote:
Please add a proper commit message here describing why this is needed.
Are there any devices with the original PID or was that just a typo?
> Signed-off-by: Preston Fick <pffick@gmail.com>
> ---
> drivers/usb/serial/cp210x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index 6c4eb3c..fb8d3fa 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -120,7 +120,7 @@ static const struct usb_device_id id_table[] = {
> { USB_DEVICE(0x10C4, 0x85F8) }, /* Virtenio Preon32 */
> { USB_DEVICE(0x10C4, 0x8664) }, /* AC-Services CAN-IF */
> { USB_DEVICE(0x10C4, 0x8665) }, /* AC-Services OBD-IF */
> - { USB_DEVICE(0x10C4, 0x8875) }, /* CEL MeshConnect USB Stick */
> + { USB_DEVICE(0x10C4, 0x8857) }, /* CEL MeshConnect USB Stick */
> { USB_DEVICE(0x10C4, 0x88A4) }, /* MMB Networks ZigBee USB Device */
> { USB_DEVICE(0x10C4, 0x88A5) }, /* Planet Innovation Ingeni ZigBee USB Device */
> { USB_DEVICE(0x10C4, 0x8946) }, /* Ketra N1 Wireless Interface */
Thanks,
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] USB: serial: cp210x: Correcting IDs for production CEL MeshConnect USB Stick
@ 2014-12-27 7:32 Preston Fick
2015-01-02 14:02 ` Johan Hovold
0 siblings, 1 reply; 4+ messages in thread
From: Preston Fick @ 2014-12-27 7:32 UTC (permalink / raw)
To: johan; +Cc: linux-usb, linux-kernel, Preston Fick
Fixing typo for MeshConnect IDs. The original PID (0x8875) is not in production and is not needed. Instead it has been changed to the official production PID (0x8857).
Signed-off-by: Preston Fick <pffick@gmail.com>
---
drivers/usb/serial/cp210x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index 6c4eb3c..fb8d3fa 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -120,7 +120,7 @@ static const struct usb_device_id id_table[] = {
{ USB_DEVICE(0x10C4, 0x85F8) }, /* Virtenio Preon32 */
{ USB_DEVICE(0x10C4, 0x8664) }, /* AC-Services CAN-IF */
{ USB_DEVICE(0x10C4, 0x8665) }, /* AC-Services OBD-IF */
- { USB_DEVICE(0x10C4, 0x8875) }, /* CEL MeshConnect USB Stick */
+ { USB_DEVICE(0x10C4, 0x8857) }, /* CEL MeshConnect USB Stick */
{ USB_DEVICE(0x10C4, 0x88A4) }, /* MMB Networks ZigBee USB Device */
{ USB_DEVICE(0x10C4, 0x88A5) }, /* Planet Innovation Ingeni ZigBee USB Device */
{ USB_DEVICE(0x10C4, 0x8946) }, /* Ketra N1 Wireless Interface */
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] USB: serial: cp210x: Correcting IDs for production CEL MeshConnect USB Stick
2014-12-27 7:32 Preston Fick
@ 2015-01-02 14:02 ` Johan Hovold
0 siblings, 0 replies; 4+ messages in thread
From: Johan Hovold @ 2015-01-02 14:02 UTC (permalink / raw)
To: Preston Fick; +Cc: johan, linux-usb, linux-kernel
On Sat, Dec 27, 2014 at 01:32:41AM -0600, Preston Fick wrote:
> Fixing typo for MeshConnect IDs. The original PID (0x8875) is not in production and is not needed. Instead it has been changed to the official production PID (0x8857).
Make sure to use line breaks in your commit messages. I fixed it up here
and applied.
Thanks,
Johan
> Signed-off-by: Preston Fick <pffick@gmail.com>
> ---
> drivers/usb/serial/cp210x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index 6c4eb3c..fb8d3fa 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -120,7 +120,7 @@ static const struct usb_device_id id_table[] = {
> { USB_DEVICE(0x10C4, 0x85F8) }, /* Virtenio Preon32 */
> { USB_DEVICE(0x10C4, 0x8664) }, /* AC-Services CAN-IF */
> { USB_DEVICE(0x10C4, 0x8665) }, /* AC-Services OBD-IF */
> - { USB_DEVICE(0x10C4, 0x8875) }, /* CEL MeshConnect USB Stick */
> + { USB_DEVICE(0x10C4, 0x8857) }, /* CEL MeshConnect USB Stick */
> { USB_DEVICE(0x10C4, 0x88A4) }, /* MMB Networks ZigBee USB Device */
> { USB_DEVICE(0x10C4, 0x88A5) }, /* Planet Innovation Ingeni ZigBee USB Device */
> { USB_DEVICE(0x10C4, 0x8946) }, /* Ketra N1 Wireless Interface */
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-02 14:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-22 5:33 [PATCH] USB: serial: cp210x: Correcting IDs for production CEL MeshConnect USB Stick Preston Fick
2014-12-23 11:24 ` Johan Hovold
-- strict thread matches above, loose matches on Subject: below --
2014-12-27 7:32 Preston Fick
2015-01-02 14:02 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox