* [PATCH 1/1] staging: skein: Delete a useless white space line
@ 2014-12-23 14:37 Kroderia
2014-12-23 15:08 ` Dan Carpenter
0 siblings, 1 reply; 13+ messages in thread
From: Kroderia @ 2014-12-23 14:37 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Kroderia
Delete a useless white space line according to the coding style.
PS: I also found some one-line macros using do {} while (0) loop,
feel like they are useless should be delete.
Signed-off-by: Kroderia <kroderia@gmail.com>
---
drivers/staging/skein/skein_generic.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
index 85bd7d0..899078f 100644
--- a/drivers/staging/skein/skein_generic.c
+++ b/drivers/staging/skein/skein_generic.c
@@ -191,7 +191,6 @@ static int __init skein_generic_init(void)
return 0;
-
unreg512:
crypto_unregister_shash(&alg512);
unreg256:
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] staging: skein: Delete a useless white space line
2014-12-23 14:37 [PATCH 1/1] staging: skein: Delete a useless white space line Kroderia
@ 2014-12-23 15:08 ` Dan Carpenter
0 siblings, 0 replies; 13+ messages in thread
From: Dan Carpenter @ 2014-12-23 15:08 UTC (permalink / raw)
To: Kroderia; +Cc: gregkh, devel, linux-kernel
On Tue, Dec 23, 2014 at 02:37:53PM +0000, Kroderia wrote:
> Delete a useless white space line according to the coding style.
>
> PS: I also found some one-line macros using do {} while (0) loop,
> feel like they are useless should be delete.
Don't put this useless information in the permanent git log.
>
> Signed-off-by: Kroderia <kroderia@gmail.com>
This doesn't seem like a legal name.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/1] staging: skein: Delete a useless white space line
@ 2014-12-23 15:37 Kroderia
2014-12-23 15:57 ` Jeremiah Mahler
0 siblings, 1 reply; 13+ messages in thread
From: Kroderia @ 2014-12-23 15:37 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Kroderia
Signed-off-by: Ben Chan <kroderia@gmail.com>
---
drivers/staging/skein/skein_generic.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
index 85bd7d0..899078f 100644
--- a/drivers/staging/skein/skein_generic.c
+++ b/drivers/staging/skein/skein_generic.c
@@ -191,7 +191,6 @@ static int __init skein_generic_init(void)
return 0;
-
unreg512:
crypto_unregister_shash(&alg512);
unreg256:
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 1/1] staging: skein: Delete a useless white space line
@ 2014-12-23 15:48 Ben Chan
2014-12-23 16:00 ` Dan Carpenter
2014-12-23 16:05 ` Jeremiah Mahler
0 siblings, 2 replies; 13+ messages in thread
From: Ben Chan @ 2014-12-23 15:48 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Kroderia
From: Kroderia <kroderia@gmail.com>
Delete a useless white space line according to the coding style.
Signed-off-by: Ben Chan <kroderia@gmail.com>
---
drivers/staging/skein/skein_generic.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
index 85bd7d0..899078f 100644
--- a/drivers/staging/skein/skein_generic.c
+++ b/drivers/staging/skein/skein_generic.c
@@ -191,7 +191,6 @@ static int __init skein_generic_init(void)
return 0;
-
unreg512:
crypto_unregister_shash(&alg512);
unreg256:
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] staging: skein: Delete a useless white space line
2014-12-23 15:37 Kroderia
@ 2014-12-23 15:57 ` Jeremiah Mahler
[not found] ` <897C311F-B3FF-4767-8D9C-22F534AA2E1E@gmail.com>
0 siblings, 1 reply; 13+ messages in thread
From: Jeremiah Mahler @ 2014-12-23 15:57 UTC (permalink / raw)
To: Kroderia; +Cc: gregkh, devel, linux-kernel
On Tue, Dec 23, 2014 at 03:37:53PM +0000, Kroderia wrote:
> Signed-off-by: Ben Chan <kroderia@gmail.com>
Your Signed-off-by doesn't match your From: line.
> ---
> drivers/staging/skein/skein_generic.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
> index 85bd7d0..899078f 100644
> --- a/drivers/staging/skein/skein_generic.c
> +++ b/drivers/staging/skein/skein_generic.c
> @@ -191,7 +191,6 @@ static int __init skein_generic_init(void)
>
> return 0;
>
> -
> unreg512:
> crypto_unregister_shash(&alg512);
> unreg256:
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
- Jeremiah Mahler
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] staging: skein: Delete a useless white space line
2014-12-23 15:48 Ben Chan
@ 2014-12-23 16:00 ` Dan Carpenter
2014-12-23 16:06 ` Gmail
2014-12-23 16:05 ` Jeremiah Mahler
1 sibling, 1 reply; 13+ messages in thread
From: Dan Carpenter @ 2014-12-23 16:00 UTC (permalink / raw)
To: Ben Chan; +Cc: gregkh, devel, linux-kernel
On Tue, Dec 23, 2014 at 03:48:16PM +0000, Ben Chan wrote:
> From: Kroderia <kroderia@gmail.com>
So very very close to being correct. Also I think someone may have
already sent this one but it just hasn't been applied because the merge
window is open. I've definitely seen this line before...
regards,
dan carpenter
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] staging: skein: Delete a useless white space line
[not found] ` <897C311F-B3FF-4767-8D9C-22F534AA2E1E@gmail.com>
@ 2014-12-23 16:04 ` Jeremiah Mahler
2014-12-23 16:09 ` Gmail
0 siblings, 1 reply; 13+ messages in thread
From: Jeremiah Mahler @ 2014-12-23 16:04 UTC (permalink / raw)
To: Gmail; +Cc: gregkh, devel, linux-kernel
On Wed, Dec 24, 2014 at 12:01:10AM +0800, Gmail wrote:
> People say that is not a legal name, therefore I create this English name sound like my real name.
>
I'm confused. So Ben Chan isn't your real name, just one you made up?
> > On Dec 23, 2014, at 11:57 PM, Jeremiah Mahler <jmmahler@gmail.com> wrote:
> >
> > On Tue, Dec 23, 2014 at 03:37:53PM +0000, Kroderia wrote:
> >> Signed-off-by: Ben Chan <kroderia@gmail.com <mailto:kroderia@gmail.com>>
> >
> > Your Signed-off-by doesn't match your From: line.
> >
> >> ---
> >> drivers/staging/skein/skein_generic.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
> >> index 85bd7d0..899078f 100644
> >> --- a/drivers/staging/skein/skein_generic.c
> >> +++ b/drivers/staging/skein/skein_generic.c
> >> @@ -191,7 +191,6 @@ static int __init skein_generic_init(void)
> >>
> >> return 0;
> >>
> >> -
> >> unreg512:
> >> crypto_unregister_shash(&alg512);
> >> unreg256:
> >> --
> >> 1.7.10.4
> >>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> >> the body of a message to majordomo@vger.kernel.org <mailto:majordomo@vger.kernel.org>
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html <http://vger.kernel.org/majordomo-info.html>
> >> Please read the FAQ at http://www.tux.org/lkml/ <http://www.tux.org/lkml/>
> >
> > --
> > - Jeremiah Mahler
>
--
- Jeremiah Mahler
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] staging: skein: Delete a useless white space line
2014-12-23 15:48 Ben Chan
2014-12-23 16:00 ` Dan Carpenter
@ 2014-12-23 16:05 ` Jeremiah Mahler
1 sibling, 0 replies; 13+ messages in thread
From: Jeremiah Mahler @ 2014-12-23 16:05 UTC (permalink / raw)
To: Ben Chan; +Cc: gregkh, devel, linux-kernel
On Tue, Dec 23, 2014 at 03:48:16PM +0000, Ben Chan wrote:
> From: Kroderia <kroderia@gmail.com>
>
> Delete a useless white space line according to the coding style.
>
> Signed-off-by: Ben Chan <kroderia@gmail.com>
Sigh. Same problem :(
> ---
> drivers/staging/skein/skein_generic.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
> index 85bd7d0..899078f 100644
> --- a/drivers/staging/skein/skein_generic.c
> +++ b/drivers/staging/skein/skein_generic.c
> @@ -191,7 +191,6 @@ static int __init skein_generic_init(void)
>
> return 0;
>
> -
> unreg512:
> crypto_unregister_shash(&alg512);
> unreg256:
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
- Jeremiah Mahler
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] staging: skein: Delete a useless white space line
2014-12-23 16:00 ` Dan Carpenter
@ 2014-12-23 16:06 ` Gmail
2014-12-23 16:14 ` Greg KH
0 siblings, 1 reply; 13+ messages in thread
From: Gmail @ 2014-12-23 16:06 UTC (permalink / raw)
To: Dan Carpenter; +Cc: gregkh, devel, linux-kernel
Thanks for your tip. People say this is not a legal name, but I really use this for all my English profile. I create another name sound like my real name and it cause this "From" display. So sorry bothering you. I will really check it and send in the future.
> On Dec 24, 2014, at 12:00 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Tue, Dec 23, 2014 at 03:48:16PM +0000, Ben Chan wrote:
>> From: Kroderia <kroderia@gmail.com>
>
> So very very close to being correct. Also I think someone may have
> already sent this one but it just hasn't been applied because the merge
> window is open. I've definitely seen this line before...
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] staging: skein: Delete a useless white space line
2014-12-23 16:04 ` Jeremiah Mahler
@ 2014-12-23 16:09 ` Gmail
0 siblings, 0 replies; 13+ messages in thread
From: Gmail @ 2014-12-23 16:09 UTC (permalink / raw)
To: Jeremiah Mahler; +Cc: gregkh, devel, linux-kernel
I am not in English, French or else, means I don't have a English name. I uses the Email's name and people said it is illegal. And then I made up Ben Chan, which really sounds like my real name.
> On Dec 24, 2014, at 12:04 AM, Jeremiah Mahler <jmmahler@gmail.com> wrote:
>
> On Wed, Dec 24, 2014 at 12:01:10AM +0800, Gmail wrote:
>> People say that is not a legal name, therefore I create this English name sound like my real name.
>>
>
> I'm confused. So Ben Chan isn't your real name, just one you made up?
>
>>> On Dec 23, 2014, at 11:57 PM, Jeremiah Mahler <jmmahler@gmail.com> wrote:
>>>
>>> On Tue, Dec 23, 2014 at 03:37:53PM +0000, Kroderia wrote:
>>>> Signed-off-by: Ben Chan <kroderia@gmail.com <mailto:kroderia@gmail.com>>
>>>
>>> Your Signed-off-by doesn't match your From: line.
>>>
>>>> ---
>>>> drivers/staging/skein/skein_generic.c | 1 -
>>>> 1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
>>>> index 85bd7d0..899078f 100644
>>>> --- a/drivers/staging/skein/skein_generic.c
>>>> +++ b/drivers/staging/skein/skein_generic.c
>>>> @@ -191,7 +191,6 @@ static int __init skein_generic_init(void)
>>>>
>>>> return 0;
>>>>
>>>> -
>>>> unreg512:
>>>> crypto_unregister_shash(&alg512);
>>>> unreg256:
>>>> --
>>>> 1.7.10.4
>>>>
>>>> --
>>>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>>>> the body of a message to majordomo@vger.kernel.org <mailto:majordomo@vger.kernel.org>
>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html <http://vger.kernel.org/majordomo-info.html>
>>>> Please read the FAQ at http://www.tux.org/lkml/ <http://www.tux.org/lkml/>
>>>
>>> --
>>> - Jeremiah Mahler
>>
>
> --
> - Jeremiah Mahler
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] staging: skein: Delete a useless white space line
2014-12-23 16:06 ` Gmail
@ 2014-12-23 16:14 ` Greg KH
2014-12-23 16:18 ` Gmail
0 siblings, 1 reply; 13+ messages in thread
From: Greg KH @ 2014-12-23 16:14 UTC (permalink / raw)
To: Gmail; +Cc: Dan Carpenter, devel, linux-kernel
On Wed, Dec 24, 2014 at 12:06:10AM +0800, Gmail wrote:
> Thanks for your tip. People say this is not a legal name, but I really
> use this for all my English profile. I create another name sound like
> my real name and it cause this "From" display. So sorry bothering you.
> I will really check it and send in the future.
What is wrong with using your legal name, there is no reason it has to
be "changed" into english at all.
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] staging: skein: Delete a useless white space line
2014-12-23 16:14 ` Greg KH
@ 2014-12-23 16:18 ` Gmail
2014-12-23 16:27 ` Greg KH
0 siblings, 1 reply; 13+ messages in thread
From: Gmail @ 2014-12-23 16:18 UTC (permalink / raw)
To: Greg KH; +Cc: Dan Carpenter, devel, linux-kernel
I found no one using the words like Chinese, Japanese here.
> On Dec 24, 2014, at 12:14 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Wed, Dec 24, 2014 at 12:06:10AM +0800, Gmail wrote:
>> Thanks for your tip. People say this is not a legal name, but I really
>> use this for all my English profile. I create another name sound like
>> my real name and it cause this "From" display. So sorry bothering you.
>> I will really check it and send in the future.
>
> What is wrong with using your legal name, there is no reason it has to
> be "changed" into english at all.
>
> greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] staging: skein: Delete a useless white space line
2014-12-23 16:18 ` Gmail
@ 2014-12-23 16:27 ` Greg KH
0 siblings, 0 replies; 13+ messages in thread
From: Greg KH @ 2014-12-23 16:27 UTC (permalink / raw)
To: Gmail; +Cc: devel, linux-kernel, Dan Carpenter
On Wed, Dec 24, 2014 at 12:18:53AM +0800, Gmail wrote:
> I found no one using the words like Chinese, Japanese here.
Not true, feel free to do so, there is no reason not to.
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2014-12-23 16:27 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-23 14:37 [PATCH 1/1] staging: skein: Delete a useless white space line Kroderia
2014-12-23 15:08 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2014-12-23 15:37 Kroderia
2014-12-23 15:57 ` Jeremiah Mahler
[not found] ` <897C311F-B3FF-4767-8D9C-22F534AA2E1E@gmail.com>
2014-12-23 16:04 ` Jeremiah Mahler
2014-12-23 16:09 ` Gmail
2014-12-23 15:48 Ben Chan
2014-12-23 16:00 ` Dan Carpenter
2014-12-23 16:06 ` Gmail
2014-12-23 16:14 ` Greg KH
2014-12-23 16:18 ` Gmail
2014-12-23 16:27 ` Greg KH
2014-12-23 16:05 ` Jeremiah Mahler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).