public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Carsten Behling <carsten.behling@ridgerun.com>
Cc: <balbi@ti.com>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: usb: musb: Scheduling of interrupt endpoints
Date: Tue, 23 Dec 2014 17:48:37 -0600	[thread overview]
Message-ID: <20141223234837.GB32702@saruman> (raw)
In-Reply-To: <5499CDB9.6050602@ridgerun.com>

[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]

Hi,

On Tue, Dec 23, 2014 at 02:16:57PM -0600, Carsten Behling wrote:
> >On Tue, Dec 23, 2014 at 08:59:39AM -0600, Carsten Behling wrote:
> >>Would it help if I send a patch as a suggestion and as basis for
> >>discussion?
> >yes, it would also help if you didn't top-post :-)
> >
> So would you suggestion be to port that feature from the old
> linux-2.6.32.17-psp03.01.01.39
> kernel from TI or should we rather add a tree based implementation as done
> for OHCI?

quite frankly, I don't know and, because of my email domain, I can't
really say out loud what I really think about those old TI releases :-)

IMHO, the best thing would be to completely ignore old kernels and
have a critical look at that part of the code on MUSB Host. Right now,
MUSB has a really brain dead endpoint allocation algorithm and it only
works for bulk (dynamic allocation, that is). Interrupt and isochronous
are left out of dynamic allocation which, IMHO, makes no sense
what so ever.

I guess the users of MUSB would benefit a whole lot more if someone were
to redesign that logic altogether so that all endpoints can be
dynamically allocated.

One easy way to test things out is to attach a ton of hubs and several
USB Serial adapters to a single MUSB port. All hubs and all USB serial
adapters - of course, as long as you follow USB spec's limitation on
maximum tier level and maximum number of devices.

cheers

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2014-12-23 23:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <54947E99.4010908@ridgerun.com>
2014-12-23 14:59 ` usb: musb: Scheduling of interrupt endpoints Carsten Behling
2014-12-23 18:27   ` Felipe Balbi
2014-12-23 20:16     ` Carsten Behling
2014-12-23 23:48       ` Felipe Balbi [this message]
2014-12-23 19:39   ` Carsten Behling
2014-12-23 23:50     ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141223234837.GB32702@saruman \
    --to=balbi@ti.com \
    --cc=carsten.behling@ridgerun.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox