From: kbuild test robot <fengguang.wu@intel.com>
To: Pravin B Shelar <pshelar@nicira.com>
Cc: kbuild-all@01.org, dev@openvswitch.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] openvswitch: fix odd_ptr_err.cocci warnings
Date: Wed, 24 Dec 2014 14:41:39 +0800 [thread overview]
Message-ID: <20141224064138.GA11360@athens> (raw)
In-Reply-To: <201412241437.BpaCtsIE%fengguang.wu@intel.com>
net/openvswitch/vport-gre.c:188:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 189
PTR_ERR should access the value just tested by IS_ERR
Semantic patch information:
There can be false positives in the patch case, where it is the call
IS_ERR that is wrong.
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
CC: Pravin B Shelar <pshelar@nicira.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
vport-gre.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/openvswitch/vport-gre.c
+++ b/net/openvswitch/vport-gre.c
@@ -186,7 +186,7 @@ static int gre_tnl_send(struct vport *vp
/* Push Tunnel header. */
skb = __build_header(skb, tunnel_hlen);
if (IS_ERR(skb)) {
- err = PTR_ERR(rt);
+ err = PTR_ERR(skb);
skb = NULL;
goto err_free_rt;
}
next parent reply other threads:[~2014-12-24 6:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201412241437.BpaCtsIE%fengguang.wu@intel.com>
2014-12-24 6:41 ` kbuild test robot [this message]
2014-12-24 18:49 ` [PATCH] openvswitch: fix odd_ptr_err.cocci warnings Pravin Shelar
2014-12-24 20:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141224064138.GA11360@athens \
--to=fengguang.wu@intel.com \
--cc=dev@openvswitch.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox