public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] staging: speakup: Split the comment to fit the length
@ 2014-12-24  4:07 Panir.Nyan
  2014-12-24  4:07 ` [PATCH 2/2] staging: speakup: Combine the consecutive string Panir.Nyan
  2014-12-24 15:41 ` [PATCH 1/2] staging: speakup: Split the comment to fit the length Samuel Thibault
  0 siblings, 2 replies; 4+ messages in thread
From: Panir.Nyan @ 2014-12-24  4:07 UTC (permalink / raw)
  To: gregkh
  Cc: w.d.hubbs, chris, kirk, samuel.thibault, speakup, devel,
	linux-kernel, Panir.Nyan

Split the comment to fit the length.

Signed-off-by: Panir Nyan <Panir.Nyan@gmail.com>
---
 drivers/staging/speakup/synth.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
index f3aa423..01eddab 100644
--- a/drivers/staging/speakup/synth.c
+++ b/drivers/staging/speakup/synth.c
@@ -30,9 +30,9 @@ struct speakup_info_t speakup_info = {
 	 * must be taken at each kernel->speakup transition and released at
 	 * each corresponding speakup->kernel transition.
 	 *
-	 * The progression thread only interferes with the speakup machinery through
-	 * the synth buffer, so only needs to take the lock while tinkering with
-	 * the buffer.
+	 * The progression thread only interferes with the speakup machinery
+	 * through the synth buffer, so only needs to take the lock
+	 * while tinkering with the buffer.
 	 *
 	 * We use spin_lock/trylock_irqsave and spin_unlock_irqrestore with this
 	 * spinlock because speakup needs to disable the keyboard IRQ.
--
1.7.10.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] staging: speakup: Combine the consecutive string
  2014-12-24  4:07 [PATCH 1/2] staging: speakup: Split the comment to fit the length Panir.Nyan
@ 2014-12-24  4:07 ` Panir.Nyan
  2014-12-24 15:44   ` Samuel Thibault
  2014-12-24 15:41 ` [PATCH 1/2] staging: speakup: Split the comment to fit the length Samuel Thibault
  1 sibling, 1 reply; 4+ messages in thread
From: Panir.Nyan @ 2014-12-24  4:07 UTC (permalink / raw)
  To: gregkh
  Cc: w.d.hubbs, chris, kirk, samuel.thibault, speakup, devel,
	linux-kernel, Panir.Nyan

Combine the consecutive string

Signed-off-by: Panir Nyan <Panir.Nyan@gmail.com>
---
 drivers/staging/speakup/kobjects.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
index b12c76d..3708bc1 100644
--- a/drivers/staging/speakup/kobjects.c
+++ b/drivers/staging/speakup/kobjects.c
@@ -566,7 +566,7 @@ ssize_t spk_var_show(struct kobject *kobj, struct kobj_attribute *attr,
 				if (ch >= ' ' && ch < '~')
 					*cp1++ = ch;
 				else
-					cp1 += sprintf(cp1, "\\""x%02x", ch);
+					cp1 += sprintf(cp1, "\\x%02x", ch);
 			}
 			*cp1++ = '"';
 			*cp1++ = '\n';
--
1.7.10.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] staging: speakup: Split the comment to fit the length
  2014-12-24  4:07 [PATCH 1/2] staging: speakup: Split the comment to fit the length Panir.Nyan
  2014-12-24  4:07 ` [PATCH 2/2] staging: speakup: Combine the consecutive string Panir.Nyan
@ 2014-12-24 15:41 ` Samuel Thibault
  1 sibling, 0 replies; 4+ messages in thread
From: Samuel Thibault @ 2014-12-24 15:41 UTC (permalink / raw)
  To: Panir.Nyan; +Cc: gregkh, w.d.hubbs, chris, kirk, speakup, devel, linux-kernel

Panir.Nyan, le Wed 24 Dec 2014 04:07:31 +0000, a écrit :
> Split the comment to fit the length.
> 
> Signed-off-by: Panir Nyan <Panir.Nyan@gmail.com>

Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  drivers/staging/speakup/synth.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
> index f3aa423..01eddab 100644
> --- a/drivers/staging/speakup/synth.c
> +++ b/drivers/staging/speakup/synth.c
> @@ -30,9 +30,9 @@ struct speakup_info_t speakup_info = {
>  	 * must be taken at each kernel->speakup transition and released at
>  	 * each corresponding speakup->kernel transition.
>  	 *
> -	 * The progression thread only interferes with the speakup machinery through
> -	 * the synth buffer, so only needs to take the lock while tinkering with
> -	 * the buffer.
> +	 * The progression thread only interferes with the speakup machinery
> +	 * through the synth buffer, so only needs to take the lock
> +	 * while tinkering with the buffer.
>  	 *
>  	 * We use spin_lock/trylock_irqsave and spin_unlock_irqrestore with this
>  	 * spinlock because speakup needs to disable the keyboard IRQ.
> --
> 1.7.10.4
> 

-- 
Samuel
Linux, c'est simple : ça s'adresse à une machine qui est parfois un peu
maraboutée mais qui d'habitude n'a pas d'états d'âme. Sur Usenet y'a
plein d'humains et de primates, et ça devient vraiment gore par moment.
-+- TP in : Guide du linuxien pervers - "Le linuxien a-t-il une âme ?" -+-

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] staging: speakup: Combine the consecutive string
  2014-12-24  4:07 ` [PATCH 2/2] staging: speakup: Combine the consecutive string Panir.Nyan
@ 2014-12-24 15:44   ` Samuel Thibault
  0 siblings, 0 replies; 4+ messages in thread
From: Samuel Thibault @ 2014-12-24 15:44 UTC (permalink / raw)
  To: Panir.Nyan; +Cc: gregkh, w.d.hubbs, chris, kirk, speakup, devel, linux-kernel

Panir.Nyan, le Wed 24 Dec 2014 04:07:32 +0000, a écrit :
> Combine the consecutive string
> 
> Signed-off-by: Panir Nyan <Panir.Nyan@gmail.com>

Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  drivers/staging/speakup/kobjects.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index b12c76d..3708bc1 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -566,7 +566,7 @@ ssize_t spk_var_show(struct kobject *kobj, struct kobj_attribute *attr,
>  				if (ch >= ' ' && ch < '~')
>  					*cp1++ = ch;
>  				else
> -					cp1 += sprintf(cp1, "\\""x%02x", ch);
> +					cp1 += sprintf(cp1, "\\x%02x", ch);
>  			}
>  			*cp1++ = '"';
>  			*cp1++ = '\n';
> --
> 1.7.10.4
> 

-- 
Samuel
"...Unix, MS-DOS, and Windows NT (also known as the Good, the Bad, and
the Ugly)."
(By Matt Welsh)

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-12-24 15:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-24  4:07 [PATCH 1/2] staging: speakup: Split the comment to fit the length Panir.Nyan
2014-12-24  4:07 ` [PATCH 2/2] staging: speakup: Combine the consecutive string Panir.Nyan
2014-12-24 15:44   ` Samuel Thibault
2014-12-24 15:41 ` [PATCH 1/2] staging: speakup: Split the comment to fit the length Samuel Thibault

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox