* [PATCH] rcu: remove "select IRQ_WORK" from config TREE_RCU
@ 2014-12-24 9:55 Lai Jiangshan
2014-12-24 18:00 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Lai Jiangshan @ 2014-12-24 9:55 UTC (permalink / raw)
To: linux-kernel, Paul E. McKenney
Cc: Lai Jiangshan, Josh Triplett, Steven Rostedt, Mathieu Desnoyers,
Andrew Morton, Michal Hocko, Vladimir Davydov, Johannes Weiner,
Geert Uytterhoeven, 蔡正龙, Bertrand Jacquin,
Luis R. Rodriguez, Fabian Frederick, Andy Lutomirski,
Pranith Kumar, Peter Foley, Mel Gorman, Clark Williams
The 48a7639ce80c ("rcu: Make callers awaken grace-period kthread")
removed the irq_work_queue(), so the TREE_RCU doesn't need
irq work any more.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
init/Kconfig | 2 --
kernel/rcu/tree.h | 1 -
2 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/init/Kconfig b/init/Kconfig
index 9afb971..39b4313 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -470,7 +470,6 @@ choice
config TREE_RCU
bool "Tree-based hierarchical RCU"
depends on !PREEMPT && SMP
- select IRQ_WORK
help
This option selects the RCU implementation that is
designed for very large SMP system with hundreds or
@@ -480,7 +479,6 @@ config TREE_RCU
config PREEMPT_RCU
bool "Preemptible tree-based hierarchical RCU"
depends on PREEMPT
- select IRQ_WORK
help
This option selects the RCU implementation that is
designed for very large SMP systems with hundreds or
diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h
index 8e7b184..a47a13c 100644
--- a/kernel/rcu/tree.h
+++ b/kernel/rcu/tree.h
@@ -27,7 +27,6 @@
#include <linux/threads.h>
#include <linux/cpumask.h>
#include <linux/seqlock.h>
-#include <linux/irq_work.h>
/*
* Define shape of hierarchy based on NR_CPUS, CONFIG_RCU_FANOUT, and
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rcu: remove "select IRQ_WORK" from config TREE_RCU
2014-12-24 9:55 [PATCH] rcu: remove "select IRQ_WORK" from config TREE_RCU Lai Jiangshan
@ 2014-12-24 18:00 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2014-12-24 18:00 UTC (permalink / raw)
To: Lai Jiangshan
Cc: linux-kernel, Josh Triplett, Steven Rostedt, Mathieu Desnoyers,
Andrew Morton, Michal Hocko, Vladimir Davydov, Johannes Weiner,
Geert Uytterhoeven, 蔡正龙, Bertrand Jacquin,
Luis R. Rodriguez, Fabian Frederick, Andy Lutomirski,
Pranith Kumar, Peter Foley, Mel Gorman, Clark Williams
On Wed, Dec 24, 2014 at 05:55:28PM +0800, Lai Jiangshan wrote:
> The 48a7639ce80c ("rcu: Make callers awaken grace-period kthread")
> removed the irq_work_queue(), so the TREE_RCU doesn't need
> irq work any more.
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Good catch, queued for 3.20. Thank you!
Thanx, Paul
> ---
> init/Kconfig | 2 --
> kernel/rcu/tree.h | 1 -
> 2 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index 9afb971..39b4313 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -470,7 +470,6 @@ choice
> config TREE_RCU
> bool "Tree-based hierarchical RCU"
> depends on !PREEMPT && SMP
> - select IRQ_WORK
> help
> This option selects the RCU implementation that is
> designed for very large SMP system with hundreds or
> @@ -480,7 +479,6 @@ config TREE_RCU
> config PREEMPT_RCU
> bool "Preemptible tree-based hierarchical RCU"
> depends on PREEMPT
> - select IRQ_WORK
> help
> This option selects the RCU implementation that is
> designed for very large SMP systems with hundreds or
> diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h
> index 8e7b184..a47a13c 100644
> --- a/kernel/rcu/tree.h
> +++ b/kernel/rcu/tree.h
> @@ -27,7 +27,6 @@
> #include <linux/threads.h>
> #include <linux/cpumask.h>
> #include <linux/seqlock.h>
> -#include <linux/irq_work.h>
>
> /*
> * Define shape of hierarchy based on NR_CPUS, CONFIG_RCU_FANOUT, and
> --
> 1.7.4.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-24 18:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-24 9:55 [PATCH] rcu: remove "select IRQ_WORK" from config TREE_RCU Lai Jiangshan
2014-12-24 18:00 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox