3.19-rc1 refuse connection from bluetooth headset

3.19-rc1 refuse connection from bluetooth headset

[Pali Rohár]

[-- Attachment #1: Type: text/plain, Size: 1909 bytes --]

Hello,

now I installed 3.19-rc1 kernel and my bluetooth headset was refused to connect automatically. I need to start 
connection manually from laptop (and then it working). Before when I started bluetooth headset it automatically 
connected and I did not have to do anything. Now with 3.19-rc1 kernel I need to do connection manually and I see 
error messages in hcidump:

 $ sudo hcidump 
 HCI sniffer - Bluetooth packet analyzer ver 2.2
 device: hci0 snap_len: 1028 filter: 0xffffffffffffffff
 > HCI Event: Connect Request (0x04) plen 10
     bdaddr <HEADSET_ADDRESS> class 0x240404 type ACL
 < HCI Command: Reject Connection Request (0x01|0x000a) plen 7
     bdaddr <HEADSET_ADDRESS> reason 0x0f
     Reason: Connection Rejected due to Unacceptable BD_ADDR
 > HCI Event: Command Status (0x0f) plen 4
     Reject Connection Request (0x01|0x000a) status 0x00 ncmd 1
 > HCI Event: Connect Complete (0x03) plen 11
     status 0x0f handle 34 bdaddr <HEADSET_ADDRESS> type ACL encrypt 0x00
     Error: Connection Rejected due to Unacceptable BD_ADDR
 > HCI Event: Connect Request (0x04) plen 10
     bdaddr <HEADSET_ADDRESS> class 0x240404 type ACL
 < HCI Command: Reject Connection Request (0x01|0x000a) plen 7
     bdaddr <HEADSET_ADDRESS> reason 0x0f
     Reason: Connection Rejected due to Unacceptable BD_ADDR
 > HCI Event: Command Status (0x0f) plen 4
     Reject Connection Request (0x01|0x000a) status 0x00 ncmd 1
 > HCI Event: Connect Complete (0x03) plen 11
    status 0x0f handle 35 bdaddr <HEADSET_ADDRESS> type ACL encrypt 0x00
    Error: Connection Rejected due to Unacceptable BD_ADDR

(real address of my bluetooth headset was replaced by <HEADSET_ADDRESS>)

Can you inspect why new kernel refuse connection from my bluetooth headset?

I'm still using bluez 4.98 (which is in Ubuntu 12.04), I did not do any update.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: 3.19-rc1 refuse connection from bluetooth headset

[Johan Hedberg]

[-- Attachment #1: Type: text/plain, Size: 2159 bytes --]

Hi Pali,

On Wed, Dec 24, 2014, Pali Rohár wrote:
> now I installed 3.19-rc1 kernel and my bluetooth headset was refused
> to connect automatically. I need to start connection manually from
> laptop (and then it working). Before when I started bluetooth headset
> it automatically connected and I did not have to do anything. Now with
> 3.19-rc1 kernel I need to do connection manually and I see error
> messages in hcidump:
> 
>  $ sudo hcidump 
>  HCI sniffer - Bluetooth packet analyzer ver 2.2
>  device: hci0 snap_len: 1028 filter: 0xffffffffffffffff
>  > HCI Event: Connect Request (0x04) plen 10
>      bdaddr <HEADSET_ADDRESS> class 0x240404 type ACL
>  < HCI Command: Reject Connection Request (0x01|0x000a) plen 7
>      bdaddr <HEADSET_ADDRESS> reason 0x0f
>      Reason: Connection Rejected due to Unacceptable BD_ADDR
>  > HCI Event: Command Status (0x0f) plen 4
>      Reject Connection Request (0x01|0x000a) status 0x00 ncmd 1
>  > HCI Event: Connect Complete (0x03) plen 11
>      status 0x0f handle 34 bdaddr <HEADSET_ADDRESS> type ACL encrypt 0x00
>      Error: Connection Rejected due to Unacceptable BD_ADDR
>  > HCI Event: Connect Request (0x04) plen 10
>      bdaddr <HEADSET_ADDRESS> class 0x240404 type ACL
>  < HCI Command: Reject Connection Request (0x01|0x000a) plen 7
>      bdaddr <HEADSET_ADDRESS> reason 0x0f
>      Reason: Connection Rejected due to Unacceptable BD_ADDR
>  > HCI Event: Command Status (0x0f) plen 4
>      Reject Connection Request (0x01|0x000a) status 0x00 ncmd 1
>  > HCI Event: Connect Complete (0x03) plen 11
>     status 0x0f handle 35 bdaddr <HEADSET_ADDRESS> type ACL encrypt 0x00
>     Error: Connection Rejected due to Unacceptable BD_ADDR
> 
> (real address of my bluetooth headset was replaced by <HEADSET_ADDRESS>)
> 
> Can you inspect why new kernel refuse connection from my bluetooth headset?
> 
> I'm still using bluez 4.98 (which is in Ubuntu 12.04), I did not do any update.

Could you try the attached patch? I think the reason might be the
dependence on the HCI_CONNECTABLE flag that's only set if the page scan
was enabled through mgmt (which wouldn't be the case with BlueZ 4.98).

Johan

[-- Attachment #2: conn-reject.patch --]
[-- Type: text/plain, Size: 570 bytes --]

diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index c03d4b09caa3..898dfd7ceeee 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -2197,7 +2197,8 @@ static void hci_conn_request_evt(struct hci_dev *hdev, struct sk_buff *skb)
 		return;
 	}
 
-	if (!test_bit(HCI_CONNECTABLE, &hdev->dev_flags) &&
+	if (test_bit(HCI_MGMT, &hdev->dev_flags) &&
+	    !test_bit(HCI_CONNECTABLE, &hdev->dev_flags) &&
 	    !hci_bdaddr_list_lookup(&hdev->whitelist, &ev->bdaddr,
 				    BDADDR_BREDR)) {
 		    hci_reject_conn(hdev, &ev->bdaddr);

Re: 3.19-rc1 refuse connection from bluetooth headset

[Pali Rohár]

[-- Attachment #1: Type: Text/Plain, Size: 2784 bytes --]

On Wednesday 24 December 2014 18:36:52 Johan Hedberg wrote:
> Hi Pali,
> 
> On Wed, Dec 24, 2014, Pali Rohár wrote:
> > now I installed 3.19-rc1 kernel and my bluetooth headset was
> > refused to connect automatically. I need to start
> > connection manually from laptop (and then it working).
> > Before when I started bluetooth headset it automatically
> > connected and I did not have to do anything. Now with
> > 3.19-rc1 kernel I need to do connection manually and I see
> > error
> > 
> > messages in hcidump:
> >  $ sudo hcidump
> >  HCI sniffer - Bluetooth packet analyzer ver 2.2
> >  device: hci0 snap_len: 1028 filter: 0xffffffffffffffff
> >  
> >  > HCI Event: Connect Request (0x04) plen 10
> >  > 
> >      bdaddr <HEADSET_ADDRESS> class 0x240404 type ACL
> >  
> >  < HCI Command: Reject Connection Request (0x01|0x000a) plen
> >  7
> >  
> >      bdaddr <HEADSET_ADDRESS> reason 0x0f
> >      Reason: Connection Rejected due to Unacceptable BD_ADDR
> >  > 
> >  > HCI Event: Command Status (0x0f) plen 4
> >  > 
> >      Reject Connection Request (0x01|0x000a) status 0x00
> >      ncmd 1
> >  > 
> >  > HCI Event: Connect Complete (0x03) plen 11
> >  > 
> >      status 0x0f handle 34 bdaddr <HEADSET_ADDRESS> type ACL
> >      encrypt 0x00 Error: Connection Rejected due to
> >      Unacceptable BD_ADDR
> >  > 
> >  > HCI Event: Connect Request (0x04) plen 10
> >  > 
> >      bdaddr <HEADSET_ADDRESS> class 0x240404 type ACL
> >  
> >  < HCI Command: Reject Connection Request (0x01|0x000a) plen
> >  7
> >  
> >      bdaddr <HEADSET_ADDRESS> reason 0x0f
> >      Reason: Connection Rejected due to Unacceptable BD_ADDR
> >  > 
> >  > HCI Event: Command Status (0x0f) plen 4
> >  > 
> >      Reject Connection Request (0x01|0x000a) status 0x00
> >      ncmd 1
> >  > 
> >  > HCI Event: Connect Complete (0x03) plen 11
> >  > 
> >     status 0x0f handle 35 bdaddr <HEADSET_ADDRESS> type ACL
> >     encrypt 0x00 Error: Connection Rejected due to
> >     Unacceptable BD_ADDR
> > 
> > (real address of my bluetooth headset was replaced by
> > <HEADSET_ADDRESS>)
> > 
> > Can you inspect why new kernel refuse connection from my
> > bluetooth headset?
> > 
> > I'm still using bluez 4.98 (which is in Ubuntu 12.04), I did
> > not do any update.
> 
> Could you try the attached patch? I think the reason might be
> the dependence on the HCI_CONNECTABLE flag that's only set if
> the page scan was enabled through mgmt (which wouldn't be the
> case with BlueZ 4.98).
> 
> Johan

Hi Johan! Thanks for quick reply. Your patch fixes my problem and 
auto-connection of my bluetooth headset is working again. Will 
you forward patch to mainline kernel?

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: 3.19-rc1 refuse connection from bluetooth headset

[Johan Hedberg]

Hi Pali,

On Wed, Dec 24, 2014, Pali Rohár wrote:
> > Could you try the attached patch? I think the reason might be
> > the dependence on the HCI_CONNECTABLE flag that's only set if
> > the page scan was enabled through mgmt (which wouldn't be the
> > case with BlueZ 4.98).
> > 
> > Johan
> 
> Hi Johan! Thanks for quick reply. Your patch fixes my problem and 
> auto-connection of my bluetooth headset is working again. Will 
> you forward patch to mainline kernel?

Yes, we'll tag it from 3.17.x onwards where this was introduced.

Johan

Re: 3.19-rc1 refuse connection from bluetooth headset

[Pali Rohár]

[-- Attachment #1: Type: Text/Plain, Size: 744 bytes --]

On Wednesday 24 December 2014 19:37:37 Johan Hedberg wrote:
> Hi Pali,
> 
> On Wed, Dec 24, 2014, Pali Rohár wrote:
> > > Could you try the attached patch? I think the reason might
> > > be the dependence on the HCI_CONNECTABLE flag that's only
> > > set if the page scan was enabled through mgmt (which
> > > wouldn't be the case with BlueZ 4.98).
> > > 
> > > Johan
> > 
> > Hi Johan! Thanks for quick reply. Your patch fixes my
> > problem and auto-connection of my bluetooth headset is
> > working again. Will you forward patch to mainline kernel?
> 
> Yes, we'll tag it from 3.17.x onwards where this was
> introduced.
> 
> Johan

Ok, you can add my Tested-by line to patch.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: 3.19-rc1 refuse connection from bluetooth headset

[Johan Hedberg]

Hi Ethan,

On Thu, Feb 12, 2015, Ethan wrote:
> I met similar issue in kernel 3.10 for Chromebook smart lock feature, I
> have merged your patch but issue still happened.

The whole feature of checking the whitelist when HCI_CONNECTABLE is not
set was introduced only in kernel version 3.18. So it makes no sense to
try to backport my patch to 3.10. If you have issues with 3.10 without
my patch then it's something else that's going on and that deserves a
separate email thread.

Johan