public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: line6: pcm: Corrected checkpatch notices in pcm.h
@ 2014-12-26 11:30 Damon Swayn
  2014-12-26 18:51 ` Konrad Zapalowicz
  0 siblings, 1 reply; 2+ messages in thread
From: Damon Swayn @ 2014-12-26 11:30 UTC (permalink / raw)
  To: gregkh; +Cc: devel, linux-kernel, Damon Swayn

Fixed a coding style issue

Signed-off-by: Damon Swayn <damon.swayn@null.net>
---
 drivers/staging/line6/pcm.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/line6/pcm.h b/drivers/staging/line6/pcm.h
index 6aa0d46..5d87934 100644
--- a/drivers/staging/line6/pcm.h
+++ b/drivers/staging/line6/pcm.h
@@ -145,21 +145,21 @@ enum {
 	    LINE6_BIT_PCM_IMPULSE_PLAYBACK_BUFFER |
 #endif
 	    LINE6_BIT_PCM_ALSA_PLAYBACK_BUFFER |
-	    LINE6_BIT_PCM_MONITOR_PLAYBACK_BUFFER ,
+	    LINE6_BIT_PCM_MONITOR_PLAYBACK_BUFFER,
 
 	LINE6_BITS_PLAYBACK_STREAM =
 #ifdef CONFIG_LINE6_USB_IMPULSE_RESPONSE
 	    LINE6_BIT_PCM_IMPULSE_PLAYBACK_STREAM |
 #endif
 	    LINE6_BIT_PCM_ALSA_PLAYBACK_STREAM |
-	    LINE6_BIT_PCM_MONITOR_PLAYBACK_STREAM ,
+	    LINE6_BIT_PCM_MONITOR_PLAYBACK_STREAM,
 
 	LINE6_BITS_CAPTURE_BUFFER =
 #ifdef CONFIG_LINE6_USB_IMPULSE_RESPONSE
 	    LINE6_BIT_PCM_IMPULSE_CAPTURE_BUFFER |
 #endif
 	    LINE6_BIT_PCM_ALSA_CAPTURE_BUFFER |
-	    LINE6_BIT_PCM_MONITOR_CAPTURE_BUFFER ,
+	    LINE6_BIT_PCM_MONITOR_CAPTURE_BUFFER,
 
 	LINE6_BITS_CAPTURE_STREAM =
 #ifdef CONFIG_LINE6_USB_IMPULSE_RESPONSE
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Staging: line6: pcm: Corrected checkpatch notices in pcm.h
  2014-12-26 11:30 [PATCH] Staging: line6: pcm: Corrected checkpatch notices in pcm.h Damon Swayn
@ 2014-12-26 18:51 ` Konrad Zapalowicz
  0 siblings, 0 replies; 2+ messages in thread
From: Konrad Zapalowicz @ 2014-12-26 18:51 UTC (permalink / raw)
  To: Damon Swayn; +Cc: gregkh, devel, linux-kernel

On 12/26, Damon Swayn wrote:
> Fixed a coding style issue

You need to be more specific here, describe what kind of issue this
patch is fixing. Keep in mind that this message, when formulated
properly, will end up as a comment to the Linux kernel source - it must,
therefore, contain valuable information.

thanks,
konrad

ps: the file name does not have to be mentioned in the subject as this
information is already in the diff.
 
> Signed-off-by: Damon Swayn <damon.swayn@null.net>
> ---
>  drivers/staging/line6/pcm.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/line6/pcm.h b/drivers/staging/line6/pcm.h
> index 6aa0d46..5d87934 100644
> --- a/drivers/staging/line6/pcm.h
> +++ b/drivers/staging/line6/pcm.h
> @@ -145,21 +145,21 @@ enum {
>  	    LINE6_BIT_PCM_IMPULSE_PLAYBACK_BUFFER |
>  #endif
>  	    LINE6_BIT_PCM_ALSA_PLAYBACK_BUFFER |
> -	    LINE6_BIT_PCM_MONITOR_PLAYBACK_BUFFER ,
> +	    LINE6_BIT_PCM_MONITOR_PLAYBACK_BUFFER,
>  
>  	LINE6_BITS_PLAYBACK_STREAM =
>  #ifdef CONFIG_LINE6_USB_IMPULSE_RESPONSE
>  	    LINE6_BIT_PCM_IMPULSE_PLAYBACK_STREAM |
>  #endif
>  	    LINE6_BIT_PCM_ALSA_PLAYBACK_STREAM |
> -	    LINE6_BIT_PCM_MONITOR_PLAYBACK_STREAM ,
> +	    LINE6_BIT_PCM_MONITOR_PLAYBACK_STREAM,
>  
>  	LINE6_BITS_CAPTURE_BUFFER =
>  #ifdef CONFIG_LINE6_USB_IMPULSE_RESPONSE
>  	    LINE6_BIT_PCM_IMPULSE_CAPTURE_BUFFER |
>  #endif
>  	    LINE6_BIT_PCM_ALSA_CAPTURE_BUFFER |
> -	    LINE6_BIT_PCM_MONITOR_CAPTURE_BUFFER ,
> +	    LINE6_BIT_PCM_MONITOR_CAPTURE_BUFFER,
>  
>  	LINE6_BITS_CAPTURE_STREAM =
>  #ifdef CONFIG_LINE6_USB_IMPULSE_RESPONSE
> -- 
> 2.1.0
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-12-26 18:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-26 11:30 [PATCH] Staging: line6: pcm: Corrected checkpatch notices in pcm.h Damon Swayn
2014-12-26 18:51 ` Konrad Zapalowicz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox