Re: [PATCH 30/38] s390: drop pte_file()-related helpers

Kirill A. Shutemov
2014-12-29T10:40:58Z

On Mon, Dec 29, 2014 at 11:07:27AM +0100, Martin Schwidefsky wrote:
> On Wed, 24 Dec 2014 14:22:38 +0200
> "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> wrote:
>
> > We've replaced remap_file_pages(2) implementation with emulation.
> > Nobody creates non-linear mapping anymore.
> >
> > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> > Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> > Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> > ---
> > @@ -279,7 +279,6 @@ static inline int is_module_addr(void *addr)
> > *
> > * pte_present is true for the bit pattern .xx...xxxxx1, (pte & 0x001) == 0x001
> > * pte_none is true for the bit pattern .10...xxxx00, (pte & 0x603) == 0x400
> > - * pte_file is true for the bit pattern .11...xxxxx0, (pte & 0x601) == 0x600
> > * pte_swap is true for the bit pattern .10...xxxx10, (pte & 0x603) == 0x402
> > */
>
> Nice, once this is upstream I can free up one of the software bits in
> the pte by redefining the type bits. Right now all of them are used up.
> Is the removal of non-linear mappings a done deal ?

Yes, if no horrible regression will be reported. We don't create
non-linear mapping in -mm (and -next) tree for a few release cycles.
Nobody complained so far.

Ack?

--
Kirill A. Shutemov