Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

Pali Rohár
2014-12-18T11:12:04Z

[-- Attachment #1: Type: Text/Plain, Size: 2213 bytes --]

On Wednesday 17 December 2014 19:20:21 Steven Honeyman wrote:
> On 17 December 2014 at 17:54, Pali Rohár <pali.rohar@gmail.com>
wrote:
> > On Wednesday 10 December 2014 12:51:30 Pali Rohár wrote:
> >> On Tuesday 09 December 2014 21:07:01 Pali Rohár wrote:
> >> > Now we have autodetection code for fan multiplier and
> >> > maximal fan speed so we do not need to have those
> >> > constants for each laptop in kernel driver code.
> >> >
> >> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> >> > ---
> >> > !!!Please do not apply this patch until all affected
> >> > machines will be tested!!!
> >> >
> >> > I tested autodetection code only on Dell Latitude E6440
> >> > (where it worked). Other machines which needs to be
> >> > tested:
> >> >
> >> > Dell Latitude D520
> >> > Dell Latitude E6540
> >> > Dell Precision WorkStation 490
> >> > Dell Studio
> >> > Dell XPS M140 (MXC051)
> >> > ---
> >>
> >> Can somebody else with dell laptops test this patch series?
> >
> > Steven Honeyman, can you test this autodetection patch on
> > your Latitude E6540?
>
> Sure. You picked the best possible time of day to ask
> (seriously!) Just applied patches 1,2,3 and so far seems
> exactly as before so it looks OK to me.
>

Good, thanks for testing. Now we know that my patches detects
correct multiplier for E6440 and E6540 machines which are in dmi
list.

> While I was spamming "sensors" I did notice this (output
> trimmed for neatness) but it is unusual my laptop fan is ever
> off so it might have always done this and I would have never
> noticed:
> Each line is about 0.5 - 1 second apart:
>
> fan2: 3186 RPM
> fan2: 3231 RPM
> <temp is low enough, fan stops>
> fan2: 10000 RPM
> fan2: 9544 RPM
> fan2: 10000 RPM
> fan2: 0 RPM
> (stays at 0 while fan is off)
> <temp back up, fan starts>
> fan2: 3236 RPM
> fan2: 3597 RPM
>
> Ever seen this before? I'd roll back and test again but this
> room and laptop are too warm for the fan to stop completely
> now.
>
>
> Thanks,
> Steven

On my E6440 I have never seen 10000 RPM.

--
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]