Re: [PATCH v2 1/2] i8k: Autodetect maximal fan speed and fan RPM multiplier

Guenter Roeck
2014-12-20T12:04:49Z

On 12/20/2014 12:57 AM, Pali Rohár wrote:
> On Friday 19 December 2014 20:28:08 Guenter Roeck wrote:
>> On Fri, Dec 19, 2014 at 07:51:25PM +0100, Pali Rohár wrote:
>>> On Friday 19 December 2014 19:32:37 Guenter Roeck wrote:
>>>>> -static int i8k_fan_mult;
>>>>> -static int i8k_pwm_mult;
>>>>> -static int i8k_fan_max = I8K_FAN_HIGH;
>>>>> +static int i8k_fan_mult[2];
>>>>> +static int i8k_pwm_mult[2];
>>>>> +static int i8k_fan_max[2];
>>>>
>>>> The rationale for this change is not explained in the
>>>> commit log.
>>>>
>>>> Do you have any indication that those values would ever be
>>>> different for the two fans, ie that you actually need
>>>> arrays here ?
>>>
>>> I do not know... But if we decide to use only single value
>>> for multiplier and max value which fan to use for
>>> autodetection?
>>
>> That does not answer my question. That you can not decide
>> which fan to use for auto-detection does not mean that the
>> result of that auto-detection would be different for
>> different fans.
>>
>
> Really I do not know if some dell products which have more fans
> (some Precision models have 2) and each fan is using different
> multiplier or has different max speed value.
>

"I do not know" is not a reason for introducing such code.

Guenter