* [PATCH] Staging: line6: remove spaces before commas.
@ 2014-12-28 13:26 Jonas Lundqvist
2014-12-28 15:44 ` Jeremiah Mahler
0 siblings, 1 reply; 6+ messages in thread
From: Jonas Lundqvist @ 2014-12-28 13:26 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Jonas Lundqvist
Fixed three errors in pcm.h found by checkpatch.pl.
Signed-off-by: Jonas Lundqvist <jonas@gannon.se>
---
drivers/staging/line6/pcm.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/line6/pcm.h b/drivers/staging/line6/pcm.h
index 6aa0d46..5d87934 100644
--- a/drivers/staging/line6/pcm.h
+++ b/drivers/staging/line6/pcm.h
@@ -145,21 +145,21 @@ enum {
LINE6_BIT_PCM_IMPULSE_PLAYBACK_BUFFER |
#endif
LINE6_BIT_PCM_ALSA_PLAYBACK_BUFFER |
- LINE6_BIT_PCM_MONITOR_PLAYBACK_BUFFER ,
+ LINE6_BIT_PCM_MONITOR_PLAYBACK_BUFFER,
LINE6_BITS_PLAYBACK_STREAM =
#ifdef CONFIG_LINE6_USB_IMPULSE_RESPONSE
LINE6_BIT_PCM_IMPULSE_PLAYBACK_STREAM |
#endif
LINE6_BIT_PCM_ALSA_PLAYBACK_STREAM |
- LINE6_BIT_PCM_MONITOR_PLAYBACK_STREAM ,
+ LINE6_BIT_PCM_MONITOR_PLAYBACK_STREAM,
LINE6_BITS_CAPTURE_BUFFER =
#ifdef CONFIG_LINE6_USB_IMPULSE_RESPONSE
LINE6_BIT_PCM_IMPULSE_CAPTURE_BUFFER |
#endif
LINE6_BIT_PCM_ALSA_CAPTURE_BUFFER |
- LINE6_BIT_PCM_MONITOR_CAPTURE_BUFFER ,
+ LINE6_BIT_PCM_MONITOR_CAPTURE_BUFFER,
LINE6_BITS_CAPTURE_STREAM =
#ifdef CONFIG_LINE6_USB_IMPULSE_RESPONSE
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Staging: line6: remove spaces before commas.
2014-12-28 13:26 [PATCH] Staging: line6: remove spaces before commas Jonas Lundqvist
@ 2014-12-28 15:44 ` Jeremiah Mahler
2014-12-28 20:30 ` Jonas Lundqvist
0 siblings, 1 reply; 6+ messages in thread
From: Jeremiah Mahler @ 2014-12-28 15:44 UTC (permalink / raw)
To: Jonas Lundqvist; +Cc: gregkh, devel, linux-kernel
Jonas,
On Sun, Dec 28, 2014 at 02:26:46PM +0100, Jonas Lundqvist wrote:
> Fixed three errors in pcm.h found by checkpatch.pl.
What type of errors did you fix?
>
> Signed-off-by: Jonas Lundqvist <jonas@gannon.se>
> ---
> drivers/staging/line6/pcm.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
[...]
--
- Jeremiah Mahler
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: line6: remove spaces before commas.
2014-12-28 15:44 ` Jeremiah Mahler
@ 2014-12-28 20:30 ` Jonas Lundqvist
2014-12-29 7:02 ` Sudip Mukherjee
0 siblings, 1 reply; 6+ messages in thread
From: Jonas Lundqvist @ 2014-12-28 20:30 UTC (permalink / raw)
To: Jeremiah Mahler, gregkh, devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 531 bytes --]
Hi Jeremiah,
On 12/28/2014 04:44 PM, Jeremiah Mahler wrote:
> Jonas,
>
> On Sun, Dec 28, 2014 at 02:26:46PM +0100, Jonas Lundqvist wrote:
>> Fixed three errors in pcm.h found by checkpatch.pl.
>
> What type of errors did you fix?
These errors:
drivers/staging/line6/pcm.h:148: ERROR: space prohibited before that ','
(ctx:WxE)
drivers/staging/line6/pcm.h:155: ERROR: space prohibited before that ','
(ctx:WxE)
drivers/staging/line6/pcm.h:162: ERROR: space prohibited before that ','
(ctx:WxE)
BR
Jonas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: line6: remove spaces before commas.
2014-12-28 20:30 ` Jonas Lundqvist
@ 2014-12-29 7:02 ` Sudip Mukherjee
2014-12-29 15:34 ` Jonas Lundqvist
0 siblings, 1 reply; 6+ messages in thread
From: Sudip Mukherjee @ 2014-12-29 7:02 UTC (permalink / raw)
To: Jonas Lundqvist; +Cc: Jeremiah Mahler, gregkh, devel, linux-kernel
On Sun, Dec 28, 2014 at 09:30:44PM +0100, Jonas Lundqvist wrote:
> Hi Jeremiah,
>
> On 12/28/2014 04:44 PM, Jeremiah Mahler wrote:
> > Jonas,
> >
> > On Sun, Dec 28, 2014 at 02:26:46PM +0100, Jonas Lundqvist wrote:
> >> Fixed three errors in pcm.h found by checkpatch.pl.
> >
> > What type of errors did you fix?
>
> These errors:
> drivers/staging/line6/pcm.h:148: ERROR: space prohibited before that ','
> (ctx:WxE)
> drivers/staging/line6/pcm.h:155: ERROR: space prohibited before that ','
> (ctx:WxE)
> drivers/staging/line6/pcm.h:162: ERROR: space prohibited before that ','
> (ctx:WxE)
I am sure Jeremiah Mahler actually wanted to tell you that you should include that information in the commit log. We always mention what kind of error was fixed.
thanks
sudip
>
>
> BR
> Jonas
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Staging: line6: remove spaces before commas.
2014-12-29 7:02 ` Sudip Mukherjee
@ 2014-12-29 15:34 ` Jonas Lundqvist
2014-12-29 17:41 ` Jeremiah Mahler
0 siblings, 1 reply; 6+ messages in thread
From: Jonas Lundqvist @ 2014-12-29 15:34 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Jonas Lundqvist
Fixed three errors in pcm.h found by checkpatch.pl:
drivers/staging/line6/pcm.h:148: ERROR: space prohibited before that ','
(ctx:WxE)
drivers/staging/line6/pcm.h:155: ERROR: space prohibited before that ','
(ctx:WxE)
drivers/staging/line6/pcm.h:162: ERROR: space prohibited before that ','
(ctx:WxE)
Signed-off-by: Jonas Lundqvist <jonas@gannon.se>
---
drivers/staging/line6/pcm.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/line6/pcm.h b/drivers/staging/line6/pcm.h
index 6aa0d46..5d87934 100644
--- a/drivers/staging/line6/pcm.h
+++ b/drivers/staging/line6/pcm.h
@@ -145,21 +145,21 @@ enum {
LINE6_BIT_PCM_IMPULSE_PLAYBACK_BUFFER |
#endif
LINE6_BIT_PCM_ALSA_PLAYBACK_BUFFER |
- LINE6_BIT_PCM_MONITOR_PLAYBACK_BUFFER ,
+ LINE6_BIT_PCM_MONITOR_PLAYBACK_BUFFER,
LINE6_BITS_PLAYBACK_STREAM =
#ifdef CONFIG_LINE6_USB_IMPULSE_RESPONSE
LINE6_BIT_PCM_IMPULSE_PLAYBACK_STREAM |
#endif
LINE6_BIT_PCM_ALSA_PLAYBACK_STREAM |
- LINE6_BIT_PCM_MONITOR_PLAYBACK_STREAM ,
+ LINE6_BIT_PCM_MONITOR_PLAYBACK_STREAM,
LINE6_BITS_CAPTURE_BUFFER =
#ifdef CONFIG_LINE6_USB_IMPULSE_RESPONSE
LINE6_BIT_PCM_IMPULSE_CAPTURE_BUFFER |
#endif
LINE6_BIT_PCM_ALSA_CAPTURE_BUFFER |
- LINE6_BIT_PCM_MONITOR_CAPTURE_BUFFER ,
+ LINE6_BIT_PCM_MONITOR_CAPTURE_BUFFER,
LINE6_BITS_CAPTURE_STREAM =
#ifdef CONFIG_LINE6_USB_IMPULSE_RESPONSE
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Staging: line6: remove spaces before commas.
2014-12-29 15:34 ` Jonas Lundqvist
@ 2014-12-29 17:41 ` Jeremiah Mahler
0 siblings, 0 replies; 6+ messages in thread
From: Jeremiah Mahler @ 2014-12-29 17:41 UTC (permalink / raw)
To: Jonas Lundqvist; +Cc: gregkh, devel, linux-kernel
Jonas,
In your subject line, when you create a new version of a patch, include
the version number. In this case it would be "[PATCH v2]".
On Mon, Dec 29, 2014 at 04:34:18PM +0100, Jonas Lundqvist wrote:
> Fixed three errors in pcm.h found by checkpatch.pl:
>
> drivers/staging/line6/pcm.h:148: ERROR: space prohibited before that ','
> (ctx:WxE)
> drivers/staging/line6/pcm.h:155: ERROR: space prohibited before that ','
> (ctx:WxE)
> drivers/staging/line6/pcm.h:162: ERROR: space prohibited before that ','
> (ctx:WxE)
>
It is better than no description at all. But listing each identical
error is redundant. I would have just said something to the effect of
"fix three space prohibited errors ...".
> Signed-off-by: Jonas Lundqvist <jonas@gannon.se>
> ---
> drivers/staging/line6/pcm.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
[...]
--
- Jeremiah Mahler
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-12-29 17:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-28 13:26 [PATCH] Staging: line6: remove spaces before commas Jonas Lundqvist
2014-12-28 15:44 ` Jeremiah Mahler
2014-12-28 20:30 ` Jonas Lundqvist
2014-12-29 7:02 ` Sudip Mukherjee
2014-12-29 15:34 ` Jonas Lundqvist
2014-12-29 17:41 ` Jeremiah Mahler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox